fix: PowerShell 5.1 compatibility for install.ps1#652
Merged
Conversation
cpojer
approved these changes
Feb 27, 2026
cpojer
reviewed
Feb 27, 2026
fengmk2
force-pushed
the
fix-pws-windows
branch
2 times, most recently
from
074d49a to
13f6aac
Compare
fengmk2
commented
Feb 27, 2026
Member
Author
|
add UTF-8 BOM to install.ps1 for PowerShell 5.1 compatibility |
- Replace 3-argument Join-Path calls with nested 2-argument calls (PS5 only supports 2 arguments) - Replace Unicode checkmark (✔) with ASCII (+) to avoid encoding issues on PS5's default console - Add PowerShell 5.1 CI job using `shell: powershell` to prevent regressions
PS5 reads .ps1 files using the system default encoding (Windows-1252) unless a UTF-8 BOM is present. Without BOM, the ✔ character's third UTF-8 byte (0x94) is misinterpreted as a double-quote in Windows-1252, causing a parser error. Adding the BOM lets PS5 correctly parse the file as UTF-8, restoring the ✔ checkmark.
fengmk2
force-pushed
the
fix-pws-windows
branch
from
13f6aac to
28ab9a4
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(PS5 only supports 2 arguments)
shell: powershellto preventregressions
closes voidzero-dev/vite-plus-discussions#14