Merged
Conversation
fengmk2
approved these changes
Mar 2, 2026
Member
|
@cpojer windows ci still fails after I retry. |
cpojer
force-pushed
the
cli-polish
branch
4 times, most recently
from
fd84514 to
bd97aa9
Compare
Merge activity
|
cpojer
force-pushed
the
cli-polish
branch
5 times, most recently
from
bd1530b to
e93abdb
Compare
fengmk2
reviewed
Mar 3, 2026
| export function replaceUnstableOutput(output: string, cwd?: string) { | ||
| // Normalize line endings and strip ANSI escapes so snapshots are stable | ||
| // across CI platforms and terminal capabilities. | ||
| output = output.replaceAll(ANSI_ESCAPE_REGEX, '').replaceAll(/\r\n/g, '\n').replaceAll(/\r/g, ''); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces general helpers to unify the printing of CLI output in Rust and in JS. As you can see from the snapshots, it already aligns a bunch of printing that was previously looking differently. It figures out the widths dynamically, which compresses output quite a bit and saves vertical space.
This was 100% done by Codex, but I think it's mostly good.
Later, I will improve the overall printing style.