feat(ci): add x86_64-apple-darwin to test and CLI E2E test matrices#671
Draft
feat(ci): add x86_64-apple-darwin to test and CLI E2E test matrices#671
Conversation
Add Intel Mac (macos-15-intel) runner to both the `test` and `cli-e2e-test` CI jobs. Update the download-rolldown-binaries action to map target triples to npm binding package names so the correct darwin-x64 binary is fetched for x86_64-apple-darwin.
fengmk2
force-pushed
the
x86_64-apple-darwin-ci
branch
from
67b9502 to
8cc880d
Compare
Use runner.os + runner.arch instead of inputs.target to select the rolldown binding. The binding runs under the host Node process, so it must match the host architecture, not the cross-compilation target.
The action now derives the platform from runner.os/runner.arch, so the target input is unused. Remove it and clean up the two call sites that were still passing it. Add an error fallthrough for unrecognized platform combinations.
Member
Author
|
tsdown sea not support macos-15-intel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Intel Mac (macos-15-intel) runner to both the
testandcli-e2e-testCI jobs. Update the download-rolldown-binaries actionto map target triples to npm binding package names so the correct
darwin-x64 binary is fetched for x86_64-apple-darwin.