Skip to content

feat(pack): align CLI arguments with tsdown upstream#672

Merged
fengmk2 merged 5 commits intomainfrom
tsdown-cli-aligned
Mar 3, 2026
Merged

feat(pack): align CLI arguments with tsdown upstream#672
fengmk2 merged 5 commits intomainfrom
tsdown-cli-aligned

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Mar 2, 2026

  • Rename --external to --deps.never-bundle to match tsdown's flag
  • Update --exe description from experimental SEA to just 'Bundle as executable'
  • Reorder --exe before --workspace to match upstream ordering
  • Add snap test for --deps.never-bundle and legacy --external backward compat

@fengmk2 fengmk2 self-assigned this Mar 2, 2026
Copy link
Copy Markdown
Member Author

fengmk2 commented Mar 2, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 marked this pull request as ready for review March 2, 2026 16:01
@fengmk2 fengmk2 requested review from Brooooooklyn and cpojer March 2, 2026 16:01
Copy link
Copy Markdown
Member Author

fengmk2 commented Mar 3, 2026

Merge activity

  • Mar 3, 2:34 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 3, 2:35 AM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 3, 2:47 AM UTC: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'done', 'CLI E2E test (windows-latest)').
  • Mar 3, 3:28 AM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 3, 3:30 AM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 3, 3:46 AM UTC: @fengmk2 merged this pull request with Graphite.

@fengmk2 fengmk2 force-pushed the tsdown-cli-aligned branch 2 times, most recently from 2c69c90 to 25245e0 Compare March 3, 2026 03:27
fengmk2 added 5 commits March 3, 2026 03:30
- Rename `--external` to `--deps.never-bundle` to match tsdown's flag
- Update `--exe` description from experimental SEA to just 'Bundle as executable'
- Reorder `--exe` before `--workspace` to match upstream ordering
- Add snap test for `--deps.never-bundle` and legacy `--external` backward compat
… key

--deps.never-bundle produced flags.deps['never-bundle'] which
resolveUserConfig() never reads, silently leaving the dependency
bundled. Using camelCase ensures cac maps it to deps.neverBundle.
@fengmk2 fengmk2 force-pushed the tsdown-cli-aligned branch from 25245e0 to 299d38b Compare March 3, 2026 03:30
@fengmk2 fengmk2 merged commit 01d0c5c into main Mar 3, 2026
18 checks passed
@fengmk2 fengmk2 deleted the tsdown-cli-aligned branch March 3, 2026 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants