fix(tools): handle mixed-separator cwd on Windows in snap test output replacement#707
Merged
fix(tools): handle mixed-separator cwd on Windows in snap test output replacement#707
Conversation
… replacement On Windows, cwd built with template literals has mixed separators (e.g., `C:\Users\...\Temp/test-name`) while Vite's error messages use all-backslash paths from path.resolve(). The cwd replacement in replaceUnstableOutput() failed to match, leaking full temp paths into snap test output. Fix by also trying the all-backslash form of cwd (and its parent) for replacement, with trailing-separator handling to normalize the path separator after the `<cwd>` placeholder.
✅ Deploy Preview for viteplus-staging canceled.
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Remove process.platform mocking in favor of describe.skipIf on non-Windows. This lets the tests exercise real Windows path.dirname behavior without workarounds for POSIX path semantics.
branchseer
approved these changes
Mar 6, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, cwd built with template literals has mixed separators
(e.g.,
C:\Users\...\Temp/test-name) while Vite's error messages useall-backslash paths from path.resolve(). The cwd replacement in
replaceUnstableOutput() failed to match, leaking full temp paths into
snap test output.
Fix by also trying the all-backslash form of cwd (and its parent) for
replacement, with trailing-separator handling to normalize the path
separator after the
<cwd>placeholder.