fix: trigger Netlify docs builds on docs/ changes#746
Merged
Conversation
Netlify's change detection watches the `base` directory. Previously `base` was set to `rfcs/`, so changes to `docs/` were invisible and builds were skipped. Now the build runs directly from `docs/`.
✅ Deploy Preview for viteplus-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…lure Netlify detects the root pnpm workspace and tries to install all dependencies, which fails on a missing patch file. Skip this step since the build command already runs `npm i --force` in docs/.
Keep base=rfcs/ to avoid pnpm workspace detection (rolldown-vite patches don't exist on Netlify), but add an ignore command that watches docs/ for changes instead of the base directory.
fengmk2
force-pushed
the
fix-docs-deploy-v2
branch
from
e03d9ea to
e835967
Compare
When $CACHED_COMMIT_REF is empty (no previous successful build), git diff compares HEAD against the working tree and finds no changes, incorrectly skipping the build. Now we exit 1 (proceed) in that case.
fengmk2
force-pushed
the
fix-docs-deploy-v2
branch
2 times, most recently
from
c20d2ff to
72e9e8c
Compare
fengmk2
force-pushed
the
fix-docs-deploy-v2
branch
from
72e9e8c to
e4c9233
Compare
fengmk2
changed the title
cpojer
approved these changes
Mar 10, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ignorecommand tonetlify.tomlthat watchesdocs/for changes, fixing builds being skipped ("No changes detected in base directory")base = "rfcs/"to avoid Netlify's auto pnpm install failing on missingrolldown-vitepatches$CACHED_COMMIT_REF(no previous successful build) by always proceedingContext
Netlify's change detection watches the
basedirectory. Withbase = "rfcs/", changes todocs/were invisible, causing builds to be skipped. We can't usebase = "docs/"because Netlify detects the root pnpm workspace and fails installing dependencies (missingrolldown-vite/patches/). Theignorecommand provides custom change detection that watchesdocs/from therfcs/base.Test plan