Skip to content

fix(migrate): use latest @oxlint/migrate instead of pinning to oxlint version #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 2 commits into from
Mar 10, 2026
Merged

fix(migrate): use latest @oxlint/migrate instead of pinning to oxlint version #751

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29c5c74
fix(migrate): resolve @oxlint/migrate version from vite-plus's own ox…
fengmk2 Mar 10, 2026
256babc
fix(migrate): use latest @oxlint/migrate instead of pinning to oxlint…
fengmk2 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions packages/cli/src/migration/migrator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import {
VITE_PLUS_NAME,
VITE_PLUS_OVERRIDE_PACKAGES,
VITE_PLUS_VERSION,
resolve,
} from '../utils/constants.js';
import { editJsonFile, isJsonFile, readJsonFile } from '../utils/json.js';
import { detectPackageMetadata } from '../utils/package.js';
Expand Down Expand Up @@ -146,13 +145,6 @@ export function detectEslintProject(
return { hasDependency, configFile, legacyConfigFile };
}

function getInstalledOxlintVersion(): string {
const oxlintMainPath = resolve('oxlint');
const oxlintPackageRoot = path.dirname(path.dirname(oxlintMainPath));
const pkgJson = readJsonFile<{ version: string }>(path.join(oxlintPackageRoot, 'package.json'));
return pkgJson.version;
}

/**
* Run a `vp dlx @oxlint/migrate` step with graceful error handling.
* Returns true on success, false on failure (spawn error or non-zero exit).
Expand Down Expand Up @@ -201,7 +193,7 @@ export async function migrateEslintToOxlint(

// Steps 1-2: Only run @oxlint/migrate if there's an eslint config at root
if (eslintConfigFile) {
const migratePackage = `@oxlint/migrate@${getInstalledOxlintVersion()}`;
const migratePackage = '@oxlint/migrate';

// Step 1: Generate .oxlintrc.json from ESLint config
spinner.start('Migrating ESLint config to Oxlint...');
Expand Down
Loading