feat(global-cli): add vp implode command to completely uninstall vite-plus#761
Merged
feat(global-cli): add vp implode command to completely uninstall vite-plus#761
vp implode command to completely uninstall vite-plus#761Conversation
✅ Deploy Preview for viteplus-staging canceled.
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
force-pushed
the
vp-global-cli-uninstall
branch
from
77d4a69 to
eb037bb
Compare
fengmk2
commented
Mar 10, 2026
VP-236 P0: Implement automatic uninstall for Vite+ (follow-up)
Problem
Task
Context
|
fengmk2
commented
Mar 10, 2026
fengmk2
commented
Mar 10, 2026
fengmk2
force-pushed
the
vp-global-cli-uninstall
branch
from
f92f5ec to
ddc454e
Compare
Brooooooklyn
approved these changes
Mar 10, 2026
fengmk2
force-pushed
the
vp-global-cli-uninstall
branch
from
19d489a to
03afb24
Compare
Brooooooklyn
approved these changes
Mar 10, 2026
fengmk2
force-pushed
the
vp-global-cli-uninstall
branch
2 times, most recently
from
2518891 to
5520b3b
Compare
Also remove implode.rs from CI paths trigger.
- Log remove_dir_all error on Windows fallback path for debugging - Print cmd.exe command and show its stdout/stderr output - Rename directory before scheduled delete to avoid racing with reinstall - Add unit tests for remove_vite_plus_dir (success + nonexistent)
…indows deferred deletion Extract `build_deferred_delete_script()` and `spawn_deferred_delete()` helpers for robustness. Move implode tests from test-standalone-install.yml to ci.yml alongside the existing upgrade tests.
…o rename + deferred delete The running vp binary is always locked, so remove_dir_all always fails with "Access is denied" — skip it and rename immediately.
fengmk2
force-pushed
the
vp-global-cli-uninstall
branch
from
5520b3b to
51f3988
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a self-uninstall command that:
.profile, config.fish) by removing Vite+ sourcing lines
locked binary via deferred cmd.exe deletion
Adds CI verification in test-standalone-install.yml for all platforms
(Unix + Windows) that tests implode followed by reinstall.
closes VP-236