fix(config): check correct path to prevent re-prompting about pre-hooks#765
Merged
fix(config): check correct path to prevent re-prompting about pre-hooks#765
Conversation
The `isFirstHooksRun` check looked for `.vite-hooks/pre-commit` (user-defined hook) but `install()` only creates `.vite-hooks/_/pre-commit` (internal shim). This caused `vp config` to re-prompt about hooks on every run.
✅ Deploy Preview for viteplus-staging canceled.
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Brooooooklyn
approved these changes
Mar 10, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
isFirstHooksRuncheck looked for.vite-hooks/pre-commit(user-definedhook) but
install()only creates.vite-hooks/_/pre-commit(internal shim).This caused
vp configto re-prompt about hooks on every run.