fix(install): suppress banner/tips and improve post-install messages#768
Merged
fix(install): suppress banner/tips and improve post-install messages#768
Conversation
✅ Deploy Preview for viteplus-staging canceled.
|
branchseer
approved these changes
Mar 10, 2026
fengmk2
changed the title
Redirect both stdout and stderr from `vp install --silent` during installation to prevent the VITE+ banner and tip text from leaking. Replace `vp dev` with `vp migrate` in the get-started section since dev is a project command unavailable after a fresh global install. Clarify the help hint to say "to see available commands".
…tput `| Out-Null 2>&1` doesn't suppress stderr in PowerShell since `2>&1` is not valid shell redirection syntax there. Use `*>$null` which redirects all PowerShell output streams (stdout, stderr, verbose, etc.).
`*>$null` is not supported in PowerShell 5.1. Use `2>&1 | Out-Null` which merges stderr into stdout then discards both, and works across PS 5.1 and PS 7+.
PowerShell 5.1 with `$ErrorActionPreference = "Stop"` converts native command stderr output into terminating NativeCommandError exceptions before the pipe to Out-Null can suppress it. Temporarily set ErrorActionPreference to SilentlyContinue around the vp install call.
…ecting output Suppress the VITE+ header when `--silent` is passed to `vp install`, and suppress tips when `CI` env var is set. This removes the need for fragile output redirection in install scripts, which was especially problematic on PowerShell 5.1 where stderr handling differs.
fengmk2
force-pushed
the
install-feedback
branch
from
a2dd5fa to
827eddf
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--silentis passed tovp installCIenv var is set, since tips are for interactive usersvp devwithvp migratein post-install "Get started" section (dev is a project command, not available after fresh global install)Test plan
cargo test -p vite_global_cli— 294 passed--silentoutput)🤖 Generated with Claude Code