Skip to content

fix: install() should replace husky hook paths instead of skipping#772

Merged
fengmk2 merged 2 commits intomainfrom
vite-hooks-fix
Mar 11, 2026
Merged

fix: install() should replace husky hook paths instead of skipping#772
fengmk2 merged 2 commits intomainfrom
vite-hooks-fix

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Mar 11, 2026

When core.hooksPath is set to .husky/_ or .husky, install() was
treating it as a genuinely custom path and refusing to overwrite. This
caused both vp config and vp migrate to skip hooks setup. Now husky
paths are recognized and replaced with .vite-hooks/_.

When `core.hooksPath` is set to `.husky/_` or `.husky`, `install()` was
treating it as a genuinely custom path and refusing to overwrite. This
caused both `vp config` and `vp migrate` to skip hooks setup. Now husky
paths are recognized and replaced with `.vite-hooks/_`.
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 11, 2026

Deploy Preview for viteplus-staging canceled.

Name Link
🔨 Latest commit e19df2f
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-staging/deploys/69b0cb86f7f53b000839ba48

Copy link
Copy Markdown
Member Author

fengmk2 commented Mar 11, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 self-assigned this Mar 11, 2026
Rename lint-staged-pre-commit-hook.md → config-and-staged-commands.md
and restructure to clarify the three entry points (vp create, vp migrate,
vp config) and their distinct responsibilities. Add "User Workflows"
section with manual setup steps, extract migration edge cases into
dedicated section, and merge fragmented command/config sections.
@fengmk2 fengmk2 marked this pull request as ready for review March 11, 2026 02:00
@fengmk2 fengmk2 requested review from Brooooooklyn and cpojer March 11, 2026 02:00
@fengmk2 fengmk2 merged commit 880214d into main Mar 11, 2026
22 checks passed
Copy link
Copy Markdown
Member Author

fengmk2 commented Mar 11, 2026

Merge activity

@fengmk2 fengmk2 deleted the vite-hooks-fix branch March 11, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants