feat: upgrade oxlint to ^1.53.0 and oxfmt to ^0.38.0, remove temp config files#776
feat: upgrade oxlint to ^1.53.0 and oxfmt to ^0.38.0, remove temp config files#776
Conversation
✅ Deploy Preview for viteplus-staging canceled.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
leaysgur
left a comment
leaysgur
left a comment
There was a problem hiding this comment.
Once this has released, we should be able to start the VSCode verification. 🆚
will release soon after merged. |
VP-158 Add `baseDir` field at oxlint and oxfmt configuration
Is it possible to add a configuration for {
"baseDir": "/foo/bar/project",
"ignorePatterns": ["dist/**"],
"extends": [
"./packages/oxlint-config/index.jsonc"
]
}Currently, our temporary solution is to create a temporary json file in the same directory as the |
fengmk2
force-pushed
the
remove-oxc-tmp-config-file
branch
from
b7d08cf to
6f30c0d
Compare
|
https://linear.app/voidzero/issue/VP-242/bug-vp-lintfmt-in-sub-workspace-should-resolve-root-config Even when running vp lint in a sub workspace, it automatically finds and passes the root workspace configuration. |
fengmk2
force-pushed
the
remove-oxc-tmp-config-file
branch
from
6f30c0d to
593b355
Compare
…fig files
oxlint@1.53 and oxfmt@0.38 support `-c vite.config.ts` directly, so the
temp file workaround (.vite-plus-lint.tmp.mts / .vite-plus-fmt.tmp.json)
is no longer needed. This removes ~150 lines of temp file creation and
cleanup machinery from SubcommandResolver.
- Bump oxfmt ^0.36.0 → ^0.38.0, oxlint ^1.51.0 → ^1.53.0
- Remove write_temp_ts_config_import, write_temp_json_config_file,
cleanup_temp_files methods and all call sites
- Pass `-c vite.config.ts` directly to oxlint/oxfmt
- Rename snap tests to reflect new behavior and enhance them to actually
verify config takes effect (lint-vite-config-rules, fmt-check-with-vite-config)
- Fix oxlint-typeaware test (add lint: {} for auto-discovery)
- Add type: module to fmt test package.json files
oxlint 1.53 and oxfmt 0.38 auto-discover vite.config.ts from CWD.
When the config lacks a `fmt` or `lint` field, they error out. This
injects `fmt: {}` defaults during create, migrate, and lint --init
flows so oxfmt auto-discovery always succeeds.
- Add `injectFmtDefaults()` in migrator.ts for create/migrate flows
- Add `injectFmtDefaultsIfMissing()` in init-config.ts for lint --init
- Extract shared `injectConfigDefaults()` helper in migrator.ts
- Add `lint: {}`/`fmt: {}` and `"type": "module"` to snap test configs
- Update snap test outputs for version upgrade changes
- Fix init-config test setup for oxfmt auto-discovery
Verify that running `vp lint` from a sub-workspace uses the root workspace's vite.config.ts lint rules and ignores the sub-workspace's own vite.config.ts configuration.
fengmk2
force-pushed
the
remove-oxc-tmp-config-file
branch
from
593b355 to
0826085
Compare
3 participants
oxlint@1.53 and oxfmt@0.38 support
-c vite.config.tsdirectly, so thetemp file workaround (.vite-plus-lint.tmp.mts / .vite-plus-fmt.tmp.json)
is no longer needed. This removes ~150 lines of temp file creation and
cleanup machinery from SubcommandResolver.
cleanup_temp_files methods and all call sites
-c vite.config.tsdirectly to oxlint/oxfmtverify config takes effect (lint-vite-config-rules, fmt-check-with-vite-config)
closes VP-158