Skip to content

fix: remove temp config file machinery re-introduced by PR #781#812

Merged
fengmk2 merged 1 commit intomainfrom
fix-oxlint-config-revert
Mar 13, 2026
Merged

fix: remove temp config file machinery re-introduced by PR #781#812
fengmk2 merged 1 commit intomainfrom
fix-oxlint-config-revert

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Mar 13, 2026

oxlint >=1.53.0 and oxfmt >=0.38.0 natively support -c vite.config.ts,
so the temp file creation/cleanup workaround is no longer needed. Pass
config files directly via -c flag instead.

Also relaxes SubcommandResolver::resolve() from &mut self to &self
since removing temp file tracking eliminates the only mutation, cascading
immutable borrows through all caller functions.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 13, 2026

Deploy Preview for viteplus-staging canceled.

Name Link
🔨 Latest commit 45b11fa
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-staging/deploys/69b39ffeccce230008f52e2d

Copy link
Copy Markdown
Member Author

fengmk2 commented Mar 13, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 self-assigned this Mar 13, 2026
@fengmk2 fengmk2 added the test: e2e Auto run e2e tests label Mar 13, 2026 — with Graphite App
@fengmk2 fengmk2 marked this pull request as ready for review March 13, 2026 04:49
@fengmk2 fengmk2 force-pushed the fix-oxlint-config-revert branch from 5eff813 to 4f9e6e3 Compare March 13, 2026 04:53
@fengmk2 fengmk2 force-pushed the fix-oxlint-config-revert branch from 4f9e6e3 to 7314136 Compare March 13, 2026 04:59
oxlint >=1.53.0 and oxfmt >=0.38.0 natively support `-c vite.config.ts`,
so the temp file creation/cleanup workaround is no longer needed. Pass
config files directly via `-c` flag instead.

Also relaxes `SubcommandResolver::resolve()` from `&mut self` to `&self`
since removing temp file tracking eliminates the only mutation, cascading
immutable borrows through all caller functions.
@fengmk2 fengmk2 force-pushed the fix-oxlint-config-revert branch from 7314136 to 45b11fa Compare March 13, 2026 05:26
@fengmk2 fengmk2 merged commit ef77182 into main Mar 13, 2026
37 checks passed
Copy link
Copy Markdown
Member Author

fengmk2 commented Mar 13, 2026

Merge activity

@fengmk2 fengmk2 deleted the fix-oxlint-config-revert branch March 13, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: e2e Auto run e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants