fix: resolve ~137 DTS warnings in vp pack when importing UserConfig#993
Merged
fengmk2 merged 18 commits intovoidzero-dev:mainfrom Mar 19, 2026
Merged
fix: resolve ~137 DTS warnings in vp pack when importing UserConfig#993fengmk2 merged 18 commits intovoidzero-dev:mainfrom
fengmk2 merged 18 commits intovoidzero-dev:mainfrom
Conversation
…nds to resolve MISSING_EXPORT warnings
✅ Deploy Preview for viteplus-preview canceled.
|
Member
|
Could you refer to https://github.com/voidzero-dev/vite-plus/blob/main/.claude/skills/add-ecosystem-ci/SKILL.md or the current snap tests code and add a corresponding e2e test case or snap test case to ensure this fix remains effective going forward? |
Collaborator
Author
|
I've already added snapshot test case and more improvement fixes. |
Member
fengmk2
reviewed
Mar 18, 2026
fengmk2
reviewed
Mar 18, 2026
fengmk2
reviewed
Mar 18, 2026
fengmk2
reviewed
Mar 18, 2026
Member
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f142fa5ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fengmk2
approved these changes
Mar 19, 2026
Member
|
@kazupon Thanks for helping to deal with this complex issue. 👍 |
TheAlexLichter
pushed a commit
that referenced
this pull request
Mar 19, 2026
…993) Fixes #991 ## Changes ### `packages/cli/src/pack-bin.ts` - Add rolldown transform plugin (`vite-plus:external-dts-type-only`) that converts `import`/`export` to `import type`/`export type` in postcss and lightningcss `.d.ts` files at bundle time - Also transforms `import * as PostCSS from "postcss"` to `import type` in `@voidzero-dev/vite-plus-core` `.d.ts` files to prevent `IMPORT_IS_UNDEFINED` warnings ### `packages/test/build.ts` - Fix `vitest/browser` path mapping from `index.js` to `context.js` to match vitest's own `package.json` exports, resolving `CDPSession` missing export - Extend `patchModuleAugmentations()` to merge augmented type definitions (e.g. `ExpectPollOptions`) into target `.d.ts` files, since rolldown cannot resolve cross-file `declare module` augmentations - Add `BrowserCommands` re-export to `context.d.ts` ## Testing - Run `vp pack` in [kazupon/vp-config](https://github.com/kazupon/vp-config) and verify zero `MISSING_EXPORT` / `IMPORT_IS_UNDEFINED` warnings --------- Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #991
Changes
packages/cli/src/pack-bin.tsvite-plus:external-dts-type-only) that convertsimport/exporttoimport type/export typein postcss and lightningcss.d.tsfiles at bundle timeimport * as PostCSS from "postcss"toimport typein@voidzero-dev/vite-plus-core.d.tsfiles to preventIMPORT_IS_UNDEFINEDwarningspackages/test/build.tsvitest/browserpath mapping fromindex.jstocontext.jsto match vitest's ownpackage.jsonexports, resolvingCDPSessionmissing exportpatchModuleAugmentations()to merge augmented type definitions (e.g.ExpectPollOptions) into target.d.tsfiles, since rolldown cannot resolve cross-filedeclare moduleaugmentationsBrowserCommandsre-export tocontext.d.tsTesting
vp packin kazupon/vp-config and verify zeroMISSING_EXPORT/IMPORT_IS_UNDEFINEDwarnings