fix: clarify task process wait errors#515
Merged
Merged
Conversation
Motivation The original spawn error was inaccurate and vague, making the failure in #506 confusing to investigate. The task had already started; the runner failed while waiting for the task process to exit, so the message should describe that lifecycle point. Changes - Report wait failures as `Failed to wait for task process to exit`. - Preserve `Failed to spawn process` for actual spawn/start and pipe failures. Co-authored-by: GPT-5 Codex <codex@openai.com>
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The original spawn error was inaccurate and vague, making the failure in #506 confusing to investigate. The task had already started; the runner failed while waiting for the task process to exit, so the message should describe that lifecycle point.
Changes
Failed to wait for task process to exit.Failed to spawn processfor actual spawn/start and pipe failures.