refactor(fspy): introduce fspy_shm facade#520
Merged
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 9, 2026
9ca03e0 to
89d699a
Compare
Co-authored-by: GPT-5.6 <gpt-5.6@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Isolate fspy shared-memory ownership behind a small internal facade so platform backends can be replaced incrementally without changing the channel layout or synchronization protocol.
Background
fspy_sharedpreviously depended directly onshared_memory::ShmemandShmemConf. That coupling made the Linux/dev/shmfix inseparable from channel code and forced every platform migration to touch the same low-level data path.Changes
fspy_shmcrate with create, open, identity, length, pointer, and slice APIs.shared_memoryimplementation on all platforms, preserving behavior in this PR.fspy_sharedproduction code and real shared-memory tests to the facade.anyhow,crossbeam-epoch, andmemmap2.