chore: group all Vite+ packages on one Renovate policy - #628
Merged
Conversation
The vite catalog entry is an npm alias for @voidzero-dev/vite-plus-core, so it misses the preset's vite+ rule (0-day minimumReleaseAge, any-time schedule) and falls under the generic npm rule (3-day age, Monday schedule). Renovate then bumps vite-plus and leaves the alias behind: main already pairs vite-plus 0.2.4 with core 0.2.2, and #593 would widen that to 0.2.8 vs 0.2.2. Add a repo rule so vite-plus and @voidzero-dev/vite-plus-* share the vite+ group and the same age and schedule. Same fix as voidzero-dev/setup-vp#121 and voidzero-dev/setup.viteplus.dev#42; see voidzero-dev/vite-plus#2356 for the general write-up.
vp pins the vitest override to the version bundled in vite-plus, so a lone vitest bump would desync the pin the same way as the vite alias. vite-task has no vitest today; the match is inert until it does.
fspy benchmarklinuxmacoswindows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
vitecatalog entry is an npm alias for@voidzero-dev/vite-plus-core, so it misses the preset's vite+ rule (0-dayminimumReleaseAge, any-time schedule) and falls under the generic npm rule (3-day age, Monday schedule). Renovate then bumpsvite-plusand leaves the alias behind: main already pairs vite-plus 0.2.4 with core 0.2.2, and #593 would widen that to 0.2.8 vs 0.2.2.Add a repo rule so
vite-plus,@voidzero-dev/vite-plus-*, andvitestshare the vite+ group and the same age and schedule. vp pins the vitest override to the version bundled in vite-plus, so a lone vitest bump would desync that pin the same way; vite-task has no vitest today, making the match inert until it does. After merging, a Renovate run should fold the alias bump to 0.2.8 into #593.Same fix as voidzero-dev/setup-vp#121 and voidzero-dev/setup.viteplus.dev#42, where Renovate folded the alias into the open update PR after the config merged. General write-up in voidzero-dev/vite-plus#2356; the preset-level fix Boshen/renovate#1 is still open, and this rule becomes redundant once it merges.