Skip to content

revert: profile overrides for artifact dependencies (#597) - #635

Merged
wan9chi merged 1 commit into
mainfrom
revert-artifact-profile-overrides
Aug 11, 2026
Merged

revert: profile overrides for artifact dependencies (#597)#635
wan9chi merged 1 commit into
mainfrom
revert-artifact-profile-overrides

Conversation

@wan9chi

@wan9chi wan9chi commented Aug 10, 2026

Copy link
Copy Markdown
Member

Motivation

#597 worked around Cargo compiling [build-dependencies] artifact deps with the build-override profile (opt-level 0 in release; rust-lang/cargo#16719) using per-package [profile.release.package.*] overrides plus the artifact_profile build-script guard. The next PR in this stack (#636) moves the artifact cdylibs to [dependencies], where the normal release profile applies in this workspace and every downstream one — making both the overrides and the guard dead machinery.

What this does

Reverts #597 (5ed7a5a): removes the three profile-override blocks, the artifact_profile crate, and its build-script guard calls from the preload and napi crates.

Note: artifact cdylibs build unoptimized between this PR and #636; the stack lands together.

🤖 Generated with Claude Code

This reverts commit 5ed7a5a.

The per-package `[profile.release.package.*]` overrides and the
`artifact_profile` build-script guard worked around Cargo compiling
`[build-dependencies]` artifact deps with the build-override profile
(rust-lang/cargo#16719). The next change in this stack moves the
artifact cdylibs to `[dependencies]`, where Cargo applies the normal
release profile in this workspace and every downstream one, making both
the overrides and the guard unnecessary.

Artifact cdylibs build unoptimized between this commit and the next;
the stack lands together.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

fspy benchmark

linux

dynamic/launch             change  +6.19%  [ -4.38% .. +17.89%]  overhead   +57.94%
dynamic/access             change +52.14%  [+48.62% .. +60.15%]  overhead   +62.00%
dynamic/access-relative    change +88.74%  [+68.53% .. +93.43%]  overhead  +175.20%
static/launch              change  +1.79%  [ -7.45% .. +12.72%]  overhead  +151.65%
static/access              change  -0.46%  [ -3.06% ..  +1.96%]  overhead  +824.03%
static/access-relative     change  -0.04%  [ -4.92% ..  +3.49%]  overhead +1337.51%

macos

dynamic/launch             change  +0.47%  [ -3.33% ..  +4.24%]  overhead  +217.13%
dynamic/access             change +28.04%  [+17.42% .. +42.25%]  overhead   +39.45%
dynamic/access-relative    change +17.36%  [ +2.13% .. +32.37%]  overhead  +320.76%

windows

dynamic/launch             change  +2.30%  [ -5.73% ..  +9.88%]  overhead   +28.69%
dynamic/access             change  +6.76%  [ +2.54% .. +18.90%]  overhead    +8.30%
dynamic/access-relative    change  +6.56%  [ +1.83% .. +15.30%]  overhead    +8.19%

@wan9chi
wan9chi merged commit 20fa982 into main Aug 11, 2026
19 checks passed
@wan9chi
wan9chi deleted the revert-artifact-profile-overrides branch August 11, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant