revert: profile overrides for artifact dependencies (#597) - #635
Merged
Conversation
This reverts commit 5ed7a5a. The per-package `[profile.release.package.*]` overrides and the `artifact_profile` build-script guard worked around Cargo compiling `[build-dependencies]` artifact deps with the build-override profile (rust-lang/cargo#16719). The next change in this stack moves the artifact cdylibs to `[dependencies]`, where Cargo applies the normal release profile in this workspace and every downstream one, making both the overrides and the guard unnecessary. Artifact cdylibs build unoptimized between this commit and the next; the stack lands together. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
fspy benchmarklinuxmacoswindows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#597 worked around Cargo compiling
[build-dependencies]artifact deps with the build-override profile (opt-level 0 in release; rust-lang/cargo#16719) using per-package[profile.release.package.*]overrides plus theartifact_profilebuild-script guard. The next PR in this stack (#636) moves the artifact cdylibs to[dependencies], where the normal release profile applies in this workspace and every downstream one — making both the overrides and the guard dead machinery.What this does
Reverts #597 (5ed7a5a): removes the three profile-override blocks, the
artifact_profilecrate, and its build-script guard calls from the preload and napi crates.Note: artifact cdylibs build unoptimized between this PR and #636; the stack lands together.
🤖 Generated with Claude Code