fix(rerank): accept sparse indexed results - #3121
Merged
MaojiaSheng merged 2 commits intoJul 11, 2026
Merged
Conversation
Collaborator
Author
|
@MaojiaSheng could you please review this focused fix for #3090? It corrects sparse OpenAI rerank result mapping and adds regression coverage; all current CI checks are passing. Thank you! |
MaojiaSheng
approved these changes
Jul 11, 2026
MaojiaSheng
reviewed
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OpenAI-compatible rerank providers may return sparse or top-N results with valid input indexes. The client rejected any result-count mismatch before reading those indexes, so the hierarchical retriever discarded valid rerank output and fell back to vector scores.
Fixes #3090.
Implementation
Validation
The two pre-existing base failures are:
Risk and gaps
The behavior change is limited to the OpenAI-compatible rerank client. Full-length responses and other rerank providers are unchanged. Missing sparse entries receive 0.0, so existing threshold and sorting logic can naturally exclude them. Validation uses a mocked provider response matching the reported shape; no live provider credentials were used.