feat(bot): bound concurrent subagents - #4614
Merged
yeshion23333 merged 1 commit intoSep 3, 2026
Merged
Conversation
yeshion23333
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Background subagents were started with
asyncio.create_task()without a capacity check, so repeated or parallelspawncalls could create unbounded concurrent LLM, sandbox, and external-tool work.This change adds a process-local limit at the shared
SubagentManager.spawn()entry point. It rejects excess spawns explicitly and reuses the existing completion cleanup to release capacity.Human Involvement
Related Issue
Closes #4613
Type of Change
Changes Made
bot.agents.subagent_max_concurrency, defaulting to4and validated as>= 1.spawncalls when the manager is at capacity.Testing
PYTHONPATH=bot:. uv run --no-project --with pytest --with pytest-asyncio --with pydantic-settings --with loguru --with pyyaml --with httpx --with fastapi --with json-repair --with litellm --with ruff -- python -m pytest --noconftest -o addopts='' -q bot/tests/test_subagent_skills_context.py bot/tests/test_channel_delivery_metadata.pyResult:
19 passed. Ruff check, Ruff format check, andgit diff --checkalso pass.Checklist
Screenshots (if applicable)
Not applicable.
Additional Notes
I chose
4as a conservative default and implemented it before waiting for a capacity decision so the trade-off is concrete. I am happy to adjust the default if maintainers prefer another value.This intentionally rejects excess requests instead of adding a queue. A queue can be added later if callers need deferred execution semantics.