Skip to content

feat: support vpn mcp server - #206

Merged
cuericlee merged 1 commit into
volcengine:mainfrom
Yuan2025801:main
Jul 29, 2025
Merged

feat: support vpn mcp server#206
cuericlee merged 1 commit into
volcengine:mainfrom
Yuan2025801:main

Conversation

@Yuan2025801

Copy link
Copy Markdown
Contributor

No description provided.

@CLAassistant

CLAassistant commented Jul 28, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Yuan2025801
Yuan2025801 force-pushed the main branch 2 times, most recently from b35262a to 96d95d9 Compare July 28, 2025 13:31

@cuericlee cuericlee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ask one more contributor or reviewer from VPN team to have a peer review.


---

### Tool 1: describe_vpn_gateway_attributes

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider to add create_xxx method to allow agent to create vpn gateway.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current vpn mcp exposes only Describe* endpoints for read‑only queries.

Comment thread server/mcp_server_vpn/pyproject.toml Outdated
readme = "README.md"
requires-python = ">=3.10"
dependencies = [
"mcp>=1.9.0",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mcp>=1.10.0

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solved

parser.add_argument(
"--transport",
"-t",
choices=["stdio", "sse"],

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add choice "streamable-http", using streamable-http instead of sse in the future.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solved

return vpn_client.describe_vpn_gateway_attributes(req)


@mcp.tool(description="调用DescribeVpnGatewayRouteAttributes查询指定VPN网关路由条目的信息")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid to use Chinese in the code, and describe more description for each arguments and output.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solved, comments change to en, modelcontextprotocol/python‑sdk examples show description field is a concise summary of what the tool does, no need to include arguments and output.

@Yuan2025801
Yuan2025801 force-pushed the main branch 2 times, most recently from f2bdbf4 to 593b351 Compare July 29, 2025 04:53
@fukuxun

fukuxun commented Jul 29, 2025

Copy link
Copy Markdown

/lgtm

@cuericlee cuericlee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cuericlee

Copy link
Copy Markdown
Collaborator

add uv.lock to ensure reproducible, consistent Python environments .

@cuericlee
cuericlee merged commit f0e488a into volcengine:main Jul 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants