Skip to content

Conversation

@0ax1
Copy link
Contributor

@0ax1 0ax1 commented Jan 28, 2026

No description provided.

@0ax1 0ax1 requested a review from joseph-isaacs January 28, 2026 19:11
@0ax1 0ax1 added the changelog/chore A trivial change label Jan 28, 2026
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 enabled auto-merge (squash) January 28, 2026 19:13
@0ax1 0ax1 merged commit a8b9c0b into develop Jan 28, 2026
42 of 45 checks passed
@0ax1 0ax1 deleted the ad/abi-include branch January 28, 2026 19:19
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 28, 2026

Merging this PR will degrade performance by 31.8%

⚡ 55 improved benchmarks
❌ 7 regressed benchmarks
✅ 1088 untouched benchmarks
⏩ 1334 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bench_compare_varbinview[(100000, 512)] 1,155 µs 964.3 µs +19.78%
Simulation bench_compare_varbinview[(100000, 4)] 1,040.1 µs 849 µs +22.5%
Simulation bench_compare_varbinview[(100000, 8)] 1,040.6 µs 850 µs +22.42%
Simulation bench_compare_primitive[(10000, 128)] 178.9 µs 159.7 µs +12.05%
Simulation bench_compare_primitive[(10000, 2)] 174.4 µs 156.4 µs +11.5%
Simulation bench_compare_primitive[(10000, 32)] 175.4 µs 156.8 µs +11.87%
Simulation bench_compare_primitive[(10000, 4)] 174.5 µs 155.2 µs +12.41%
Simulation bench_compare_primitive[(10000, 512)] 193.7 µs 174.6 µs +10.96%
Simulation bench_compare_primitive[(10000, 8)] 174.5 µs 155.5 µs +12.21%
Simulation bench_compare_primitive[(100000, 128)] 1,037.8 µs 847.6 µs +22.44%
Simulation bench_compare_primitive[(100000, 8)] 1,033.5 µs 843.3 µs +22.56%
Simulation bench_compare_primitive[(100000, 32)] 1,034.7 µs 844.9 µs +22.47%
Simulation bench_compare_primitive[(100000, 2)] 1,033.4 µs 843.2 µs +22.55%
Simulation bench_compare_primitive[(100000, 512)] 1,095.6 µs 905.3 µs +21.03%
Simulation bench_compare_primitive[(100000, 2048)] 1,136.5 µs 946.7 µs +20.05%
Simulation bench_compare_primitive[(100000, 4)] 1,033.7 µs 843.3 µs +22.57%
Simulation bench_compare_varbin[(10000, 32)] 184.5 µs 165.1 µs +11.74%
Simulation bench_compare_varbin[(10000, 128)] 197.4 µs 178.3 µs +10.74%
Simulation bench_compare_varbin[(100000, 128)] 1,056.3 µs 865.8 µs +22%
Simulation bench_compare_varbin[(10000, 8)] 181.1 µs 161.9 µs +11.84%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing ad/abi-include (bceab79) with develop (68130ce)2

Open in CodSpeed

Footnotes

  1. 1334 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (d334647) during the generation of this report, so 68130ce was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

0ax1 added a commit that referenced this pull request Jan 28, 2026
This reverts commit a8b9c0b.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
0ax1 added a commit that referenced this pull request Jan 28, 2026
This reverts commit a8b9c0b.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants