Skip to content

Conversation

@0ax1
Copy link
Contributor

@0ax1 0ax1 commented Jan 28, 2026

This reverts commit a8b9c0b.

This reverts commit a8b9c0b.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 requested a review from joseph-isaacs January 28, 2026 19:26
@0ax1 0ax1 added the changelog/chore A trivial change label Jan 28, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 28, 2026

Merging this PR will degrade performance by 31.8%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 55 improved benchmarks
❌ 7 regressed benchmarks
✅ 1099 untouched benchmarks
🆕 18 new benchmarks
⏩ 1323 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
🆕 WallTime 1M_10pct[100000] N/A 22.2 µs N/A
🆕 WallTime 1M_10pct[100000] N/A 50.1 µs N/A
🆕 WallTime 1M_10pct[100000] N/A 41.8 µs N/A
🆕 WallTime 10M_10pct[1000000] N/A 221.3 µs N/A
🆕 WallTime 1M_50pct[500000] N/A 46.1 µs N/A
🆕 WallTime 10M_50pct[5000000] N/A 159 µs N/A
🆕 WallTime 1M_50pct[500000] N/A 50 µs N/A
🆕 WallTime 10M_10pct[1000000] N/A 221.9 µs N/A
🆕 WallTime 1M_90pct[1000000] N/A 57.3 µs N/A
🆕 WallTime 1M_90pct[1000000] N/A 30.3 µs N/A
🆕 WallTime 10M_90pct[10000000] N/A 365.6 µs N/A
🆕 WallTime 10M_90pct[10000000] N/A 362.8 µs N/A
🆕 WallTime 10M_50pct[5000000] N/A 281.6 µs N/A
🆕 WallTime 10M_10pct[1000000] N/A 131.9 µs N/A
🆕 WallTime 10M_50pct[5000000] N/A 279.9 µs N/A
🆕 WallTime 1M_50pct[500000] N/A 22.8 µs N/A
🆕 WallTime 10M_90pct[10000000] N/A 195.5 µs N/A
🆕 WallTime 1M_90pct[1000000] N/A 56.7 µs N/A
Simulation bench_compare_primitive[(10000, 128)] 178.9 µs 159.7 µs +12.05%
Simulation bench_compare_primitive[(10000, 32)] 175.4 µs 156.8 µs +11.87%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing ad/revert (647aaf1) with develop (68130ce)2

Open in CodSpeed

Footnotes

  1. 1323 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (a8b9c0b) during the generation of this report, so 68130ce was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@0ax1 0ax1 enabled auto-merge (squash) January 28, 2026 19:43
Copy link
Contributor

@connortsui20 connortsui20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo

@0ax1 0ax1 merged commit 0981ab1 into develop Jan 28, 2026
45 of 48 checks passed
@0ax1 0ax1 deleted the ad/revert branch January 28, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants