Skip to content

IsConstant Aggregate Function#7028

Merged
gatesn merged 9 commits intodevelopfrom
ngates/is-constant
Mar 19, 2026
Merged

IsConstant Aggregate Function#7028
gatesn merged 9 commits intodevelopfrom
ngates/is-constant

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Mar 18, 2026

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 18, 2026

Merging this PR will degrade performance by 15.51%

❌ 2 regressed benchmarks
✅ 1007 untouched benchmarks
⏩ 1515 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[128] 317.8 ns 376.1 ns -15.51%
Simulation bitwise_not_vortex_buffer_mut[1024] 477.2 ns 535.6 ns -10.89%

Comparing ngates/is-constant (360fe14) with develop (a98f94c)

Open in CodSpeed

Footnotes

  1. 1515 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn gatesn added the changelog/feature A new feature label Mar 18, 2026
@gatesn gatesn marked this pull request as ready for review March 18, 2026 21:51
@gatesn gatesn requested a review from robert3005 March 18, 2026 21:51
@gatesn gatesn enabled auto-merge (squash) March 18, 2026 22:03
Copy link
Contributor Author

gatesn commented Mar 18, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gatesn gatesn mentioned this pull request Mar 18, 2026
Copy link
Contributor

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a weird todo there

gatesn added 9 commits March 18, 2026 17:25
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn force-pushed the ngates/is-constant branch from 71468be to 360fe14 Compare March 19, 2026 00:25
@gatesn gatesn merged commit 644fcdf into develop Mar 19, 2026
54 of 55 checks passed
@gatesn gatesn deleted the ngates/is-constant branch March 19, 2026 00:33
dimitarvdimitrov pushed a commit that referenced this pull request Mar 20, 2026
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants