Skip to content

IsSorted AggregateFn#7029

Merged
gatesn merged 10 commits intodevelopfrom
ngates/is-sorted
Mar 19, 2026
Merged

IsSorted AggregateFn#7029
gatesn merged 10 commits intodevelopfrom
ngates/is-sorted

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Mar 18, 2026

Port IsSorted compute function over to an AggregateFn

Copy link
Contributor Author

gatesn commented Mar 18, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gatesn gatesn changed the title IsSortedKernel IsSorted AggregateFn Mar 18, 2026
@gatesn gatesn added the changelog/feature A new feature label Mar 18, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 18, 2026

Merging this PR will degrade performance by 19.17%

⚡ 11 improved benchmarks
❌ 6 regressed benchmarks
✅ 992 untouched benchmarks
⏩ 1515 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation i32_small_overlapping 69.1 µs 77 µs -10.21%
Simulation old_alp_prim_test_between[f32, 32768] 445 µs 398.5 µs +11.67%
Simulation new_bp_prim_test_between[i16, 32768] 139.5 µs 126.3 µs +10.42%
Simulation new_bp_prim_test_between[i64, 32768] 235.4 µs 176.8 µs +33.1%
Simulation old_bp_prim_test_between[i64, 16384] 324.8 µs 294.7 µs +10.23%
Simulation new_bp_prim_test_between[i32, 16384] 110.4 µs 96.3 µs +14.69%
Simulation new_bp_prim_test_between[i64, 16384] 142.4 µs 112.9 µs +26.18%
Simulation new_bp_prim_test_between[i32, 32768] 172.7 µs 144.2 µs +19.74%
Simulation patched_take_10k_first_chunk_only 282.9 µs 341.8 µs -17.21%
Simulation patched_take_10k_contiguous_not_patches 248.5 µs 307.4 µs -19.17%
Simulation patched_take_10k_dispersed 296.8 µs 355.6 µs -16.54%
Simulation patched_take_10k_random 260 µs 318.9 µs -18.46%
Simulation patched_take_10k_contiguous_patches 248.3 µs 307.2 µs -19.15%
Simulation new_alp_prim_test_between[f64, 16384] 147.2 µs 125.5 µs +17.27%
Simulation old_bp_prim_test_between[i64, 32768] 537 µs 475.2 µs +12.99%
Simulation decompress_utf8[(1000, 4)] 43.1 µs 39 µs +10.59%
Simulation null_count_run_end[(10000, 4, 0.01)] 113.1 µs 99.2 µs +13.99%

Comparing ngates/is-sorted (4878eed) with develop (3cf3a17)

Open in CodSpeed

Footnotes

  1. 1515 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn gatesn force-pushed the ngates/is-constant branch from 71468be to 360fe14 Compare March 19, 2026 00:25
@gatesn gatesn force-pushed the ngates/is-sorted branch from f9649f2 to 3be8923 Compare March 19, 2026 00:25
@gatesn gatesn requested a review from robert3005 March 19, 2026 00:26
@gatesn gatesn marked this pull request as ready for review March 19, 2026 00:27
Base automatically changed from ngates/is-constant to develop March 19, 2026 00:33
gatesn added 7 commits March 18, 2026 17:40
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn force-pushed the ngates/is-sorted branch from 01fa8ee to 0b9780e Compare March 19, 2026 00:42
@gatesn gatesn enabled auto-merge (squash) March 19, 2026 00:43
gatesn added 2 commits March 18, 2026 18:13
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn merged commit ec85ffe into develop Mar 19, 2026
54 of 56 checks passed
@gatesn gatesn deleted the ngates/is-sorted branch March 19, 2026 02:07
dimitarvdimitrov pushed a commit that referenced this pull request Mar 20, 2026
Port IsSorted compute function over to an AggregateFn

---------

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants