Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Resolve conflicts keeping the HashSet<ArrayId>-based allowed encodings approach from this branch. Remove duplicate with_slots method from auto-merge and clean up unused imports. Signed-off-by: Joe Isaacs <joe@spiraldb.com>
joseph-isaacs
approved these changes
Apr 7, 2026
Merging this PR will degrade performance by 23.82%
Performance Changes
Comparing Footnotes
|
The NormalizeOptions API expects HashSet<Id>, not ArrayRegistry. Update CudaFlatLayoutStrategy to match. Also clean up unused imports in strategy.rs from the merge. Signed-off-by: Joe Isaacs <joe@spiraldb.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Remove unused imports from merge (ArrayRegistry, ArrayPluginRef, Primitive) in flat writer tests. Fix redundant clone in normalize test. Regenerate public API lock files. Signed-off-by: Joe Isaacs <joe@spiraldb.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Remove unused imports from merge (ArrayRegistry, ArrayPluginRef, Primitive) in flat writer tests. Fix redundant clone in normalize test. Regenerate public API lock files. Signed-off-by: Joe Isaacs <joe@spiraldb.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
…hildren Dict arrays contain Primitive codes and values, so the allowed encodings set must include Primitive in addition to Dict. Signed-off-by: Joe Isaacs <joe@spiraldb.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
…ortex into ngates/normalize-execution
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow execution during normalization