Add extension constant pushdown rule and fix InnerProduct rule#7507
Merged
connortsui20 merged 1 commit intodevelopfrom Apr 17, 2026
Merged
Add extension constant pushdown rule and fix InnerProduct rule#7507connortsui20 merged 1 commit intodevelopfrom
InnerProduct rule#7507connortsui20 merged 1 commit intodevelopfrom
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
added
action/benchmark
github-actions
bot
removed
the
action/benchmark
Merging this PR will degrade performance by 16.95%
Performance Changes
Comparing 
Footnotes
|
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 0.944x ➖ datafusion / vortex-file-compressed (0.944x ➖, 3↑ 0↓)
|
Contributor
File Sizes: PolarSignals ProfilingNo file size changes detected. |
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.072x ➖, 0↑ 3↓)
datafusion / vortex-compact (1.074x ➖, 0↑ 2↓)
datafusion / parquet (1.046x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.093x ➖, 0↑ 4↓)
duckdb / vortex-compact (1.184x ❌, 0↑ 7↓)
duckdb / parquet (1.093x ➖, 0↑ 2↓)
Full attributed analysis
|
Contributor
File Sizes: FineWeb NVMeNo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.991x ➖, 0↑ 0↓)
datafusion / vortex-compact (1.004x ➖, 0↑ 0↓)
datafusion / parquet (1.004x ➖, 0↑ 0↓)
datafusion / arrow (1.059x ➖, 0↑ 2↓)
duckdb / vortex-file-compressed (1.009x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.009x ➖, 0↑ 0↓)
duckdb / parquet (0.977x ➖, 2↑ 0↓)
duckdb / duckdb (0.977x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.876x ✅, 56↑ 0↓)
datafusion / vortex-compact (0.793x ✅, 93↑ 0↓)
datafusion / parquet (0.941x ➖, 32↑ 14↓)
duckdb / vortex-file-compressed (0.818x ✅, 91↑ 1↓)
duckdb / vortex-compact (0.850x ✅, 84↑ 1↓)
duckdb / parquet (0.862x ✅, 80↑ 0↓)
duckdb / duckdb (0.820x ✅, 88↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-DS SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.846x ➖, 1↑ 0↓)
datafusion / vortex-compact (0.913x ➖, 1↑ 2↓)
datafusion / parquet (0.927x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.936x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.902x ➖, 0↑ 0↓)
duckdb / parquet (0.916x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Random AccessVortex (geomean): 0.847x ✅ unknown / unknown (0.931x ➖, 11↑ 0↓)
|
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.040x ➖, 0↑ 2↓)
datafusion / vortex-compact (1.065x ➖, 0↑ 9↓)
datafusion / parquet (1.013x ➖, 0↑ 0↓)
datafusion / arrow (1.006x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.084x ➖, 0↑ 8↓)
duckdb / vortex-compact (1.100x ➖, 0↑ 12↓)
duckdb / parquet (1.047x ➖, 0↑ 1↓)
duckdb / duckdb (1.050x ➖, 0↑ 2↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=10 on NVMENo file size changes detected. |
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (1.116x ❌, 0↑ 5↓)
duckdb / vortex-compact (1.047x ➖, 0↑ 2↓)
duckdb / parquet (1.097x ➖, 0↑ 8↓)
Full attributed analysis
|
Contributor
File Sizes: Statistical and Population GeneticsNo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.823x ➖, 4↑ 0↓)
datafusion / vortex-compact (0.845x ➖, 3↑ 1↓)
datafusion / parquet (1.002x ➖, 1↑ 2↓)
duckdb / vortex-file-compressed (0.959x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.945x ➖, 0↑ 0↓)
duckdb / parquet (0.945x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: CompressionVortex (geomean): 1.003x ➖ unknown / unknown (0.999x ➖, 0↑ 1↓)
|
Contributor
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.918x ➖, 1↑ 1↓)
datafusion / vortex-compact (0.795x ➖, 4↑ 0↓)
datafusion / parquet (0.784x ➖, 6↑ 0↓)
duckdb / vortex-file-compressed (0.969x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.028x ➖, 0↑ 0↓)
duckdb / parquet (0.956x ➖, 0↑ 0↓)
Full attributed analysis
|
connortsui20
added a commit
that referenced
this pull request
Apr 17, 2026
## Summary Fixes the regression caused by #7507 The reduction rule would go from `Extension(Constant(..))` into `Constant(Extension(..))`, but the `execute` would just revert that, creating a cycle! ## Testing N/A Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Most of our optimizer rules interact with
ConstantArray, as often there is an optimized implementation when a child is known to be constant.We can have both of these arrays that mean the same thing, but the second is not easily matched on:
This change adds a rule to convert the second representation into the first. It additionally fixes a bug in the
InnerProductreduction (right now it is inexecutebut it should really be a reduction rule, that will come in the future) where it checks for the second case instead of the first.Testing
Basic tests.