Merged
Conversation
connortsui20
added
changelog/fix
github-actions
bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/execute-constant-extension
branch
from
0a03eea to
c3ddec1
Compare
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.026x ➖ datafusion / vortex-file-compressed (1.026x ➖, 0↑ 0↓)
|
Contributor
File Sizes: PolarSignals ProfilingNo file size changes detected. |
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.990x ➖, 1↑ 0↓)
datafusion / vortex-compact (1.049x ➖, 0↑ 2↓)
datafusion / parquet (0.990x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.946x ➖, 2↑ 0↓)
duckdb / vortex-compact (1.011x ➖, 0↑ 0↓)
duckdb / parquet (0.940x ➖, 2↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: FineWeb NVMeNo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.990x ➖, 1↑ 0↓)
datafusion / vortex-compact (0.991x ➖, 0↑ 0↓)
datafusion / parquet (0.988x ➖, 2↑ 0↓)
datafusion / arrow (1.012x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (1.071x ➖, 0↑ 2↓)
duckdb / vortex-compact (1.024x ➖, 0↑ 2↓)
duckdb / parquet (1.020x ➖, 0↑ 2↓)
duckdb / duckdb (0.997x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.108x ❌, 0↑ 54↓)
datafusion / vortex-compact (1.083x ➖, 0↑ 26↓)
datafusion / parquet (1.095x ➖, 0↑ 41↓)
duckdb / vortex-file-compressed (1.104x ❌, 0↑ 59↓)
duckdb / vortex-compact (1.085x ➖, 0↑ 37↓)
duckdb / parquet (1.068x ➖, 0↑ 20↓)
duckdb / duckdb (1.071x ➖, 0↑ 30↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-DS SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.740x ➖, 4↑ 1↓)
datafusion / vortex-compact (1.389x ❌, 0↑ 4↓)
datafusion / parquet (1.017x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.006x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.128x ➖, 0↑ 2↓)
duckdb / parquet (1.028x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Random AccessVortex (geomean): 0.891x ✅ unknown / unknown (0.979x ➖, 7↑ 3↓)
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (1.032x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.030x ➖, 0↑ 0↓)
duckdb / parquet (0.999x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: Statistical and Population GeneticsNo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.067x ➖, 0↑ 7↓)
datafusion / vortex-compact (1.064x ➖, 0↑ 0↓)
datafusion / parquet (1.071x ➖, 0↑ 5↓)
datafusion / arrow (1.079x ➖, 0↑ 4↓)
duckdb / vortex-file-compressed (1.050x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.059x ➖, 0↑ 1↓)
duckdb / parquet (1.023x ➖, 0↑ 0↓)
duckdb / duckdb (1.042x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=10 on NVMENo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.942x ➖, 1↑ 0↓)
datafusion / vortex-compact (1.090x ➖, 0↑ 4↓)
datafusion / parquet (1.053x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed (1.046x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.033x ➖, 0↑ 0↓)
duckdb / parquet (1.035x ➖, 0↑ 0↓)
Full attributed analysis
|
a10y
reviewed
Apr 17, 2026
Comment on lines
+171
to
+174
| // NB: We need to execute the constant array to be canonical because there is a | ||
| // reduction rule that turns `Extension(Constant(..))` into `Constant(Extension(..))`, | ||
| // and if we don't do this we create an infinite cycle. | ||
| // See `ExtensionConstantRule` for more details. |
Contributor
There was a problem hiding this comment.
should we just remove the reduction rule?
Contributor
Author
There was a problem hiding this comment.
It's kind of hard to say since if we don't remove that reduction rule, all of our optimizations that look for a ConstantArray child now don't work.
Contributor
There was a problem hiding this comment.
We should keep the rule 100%. We must have a standard way to check is constant.
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.030x ➖, 0↑ 3↓)
datafusion / parquet (1.052x ➖, 0↑ 5↓)
duckdb / vortex-file-compressed (0.997x ➖, 8↑ 2↓)
duckdb / parquet (1.016x ➖, 0↑ 0↓)
duckdb / duckdb (0.974x ➖, 4↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: Clickbench on NVMEFile Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
Benchmarks: CompressionVortex (geomean): 1.002x ➖ unknown / unknown (1.004x ➖, 0↑ 1↓)
|
Contributor
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.032x ➖, 0↑ 2↓)
datafusion / vortex-compact (1.114x ➖, 0↑ 0↓)
datafusion / parquet (1.017x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed (1.087x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.084x ➖, 0↑ 0↓)
duckdb / parquet (1.071x ➖, 0↑ 1↓)
Full attributed analysis
|
Contributor
Author
|
i dont really believe the TPC-H SF1 regression is real given SF10 is fine |
joseph-isaacs
approved these changes
Apr 17, 2026
Contributor
joseph-isaacs
left a comment
joseph-isaacs
left a comment
There was a problem hiding this comment.
We should add a cycle detection mode to executor for debug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the regression caused by #7507
The reduction rule would go from
Extension(Constant(..))intoConstant(Extension(..)), but theexecutewould just revert that, creating a cycle!Testing
N/A