Skip to content

Use dev profile for editable python builds#7510

Merged
AdamGS merged 3 commits intodevelopfrom
adamg/use-editable-profile-maturin
Apr 17, 2026
Merged

Use dev profile for editable python builds#7510
AdamGS merged 3 commits intodevelopfrom
adamg/use-editable-profile-maturin

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented Apr 17, 2026

Summary

Has this ever happened to you? You just want to make some minor change, or run some small uv command, and suddenly you're re-building all of Vortex in release mode and your laptop sounds like a jet taking off.

Now you don't have to do that! Any editable build (which is the default thing uv does) build will be in dev profile, while things like maturin develop -r or our publishing will stay in release mode.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested review from danking, gatesn and robert3005 April 17, 2026 11:26
@AdamGS AdamGS added changelog/chore A trivial change lang/python Relates to the Vortex Python API labels Apr 17, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 17, 2026

Merging this PR will degrade performance by 17.35%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 1161 untouched benchmarks
⏩ 1457 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 1.0)] 1.7 ms 2 ms -17.35%
Simulation new_alp_prim_test_between[f32, 16384] 120.4 µs 106.1 µs +13.5%

Comparing adamg/use-editable-profile-maturin (c8c07d8) with develop (6ebb797)

Open in CodSpeed

Footnotes

  1. 1457 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

AdamGS added 2 commits April 17, 2026 12:34
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested a review from robert3005 April 17, 2026 11:44
logging.basicConfig(level=logging.DEBUG)


def pytest_sessionstart():
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also removed this test plugin that I think tried to avoid expensie rebuilds when running tests, now even a clean build will just build everything with a dev profile so this is unnecessery

@AdamGS AdamGS merged commit 7c32db0 into develop Apr 17, 2026
60 of 61 checks passed
@AdamGS AdamGS deleted the adamg/use-editable-profile-maturin branch April 17, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change lang/python Relates to the Vortex Python API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants