Skip to content

Use dev profile for editable python builds #7510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdamGS merged 3 commits into from
Apr 17, 2026
+22 −34
Merged

Use dev profile for editable python builds #7510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f41a8cf
Use dev profile for editable python builds
AdamGS Apr 17, 2026
3ed8905
Dry run with same maturin version we release with
AdamGS Apr 17, 2026
c8c07d8
No need to have an implicit local build anymore
AdamGS Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/publish-dry-runs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ jobs:
rm -rf ../target/wheels/
uv venv
uv tool run maturin@1.10 build --interpreter python3.11 --zig
uv tool run maturin@1.10 build --interpreter python3.11 --zig --sdist
uv tool run maturin@1.10.2 build --interpreter python3.11 --zig
uv tool run maturin@1.10.2 build --interpreter python3.11 --zig --sdist
file_count=$(ls -1 ../target/wheels/ | wc -l)
Expand Down
32 changes: 16 additions & 16 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions vortex-python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,15 @@ Issues = "https://github.com/vortex-data/vortex/issues"
Benchmarks = "https://bench.vortex.dev"

[build-system]
requires = ["maturin>=1.7.2,<2.0"]
requires = ["maturin>=1.10.2,<2.0"]
build-backend = "maturin"

[tool.uv]
managed = true

[tool.maturin]
profile = "release"
editable-profile = "dev"
python-source = "python"
module-name = "vortex._lib"
features = ["pyo3/extension-module", "mimalloc"]
Expand All @@ -70,7 +72,7 @@ include = [
[dependency-groups]
dev = [
"duckdb>=1.1.2",
"maturin>=1.7.2",
"maturin>=1.10.2",
"numpy>=2.2.2",
"pandas-stubs>=2.2.3.241126",
"pandas[output-formatting]>=2.2.3",
Expand Down
14 changes: 0 additions & 14 deletions vortex-python/test/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,5 @@
# SPDX-FileCopyrightText: Copyright the Vortex contributors

import logging
import os
import pathlib
import subprocess

logging.basicConfig(level=logging.DEBUG)


def pytest_sessionstart():
Copy link
Copy Markdown
Contributor Author

@AdamGS AdamGS Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also removed this test plugin that I think tried to avoid expensie rebuilds when running tests, now even a clean build will just build everything with a dev profile so this is unnecessery

"""Pytest plugin to trigger maturin builds before running tests."""
if os.environ.get("CI") is None:
# Running maturin develop --skip-install builds a "linux" wheel which PyPI rejects
# (https://peps.python.org/pep-0513/#rationale). When testing an already built wheel, we
# neither want to rebuild nor pollute the target/wheels directory with a wheel that PyPI
# will reject.
working_dir = pathlib.Path(__file__).parent.parent
_ = subprocess.check_call(["maturin", "develop", "--skip-install"], cwd=working_dir)
Loading