Bump msrv and rust-toolchain to 1.91 (and lance for benchmarks)#7595
Merged
connortsui20 merged 3 commits intodevelopfrom Apr 22, 2026
Merged
Bump msrv and rust-toolchain to 1.91 (and lance for benchmarks)#7595connortsui20 merged 3 commits intodevelopfrom
connortsui20 merged 3 commits intodevelopfrom
Conversation
Merging this PR will degrade performance by 60.31%
Performance Changes
Comparing 
|
Contributor
|
We have agreed to last 3 major versions just like datafusion. We can upgrade if there’s a reason |
github-actions
Bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.042x ➖ datafusion / vortex-file-compressed (1.042x ➖, 0↑ 2↓)
|
Contributor
File Sizes: PolarSignals ProfilingNo file size changes detected. |
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.048x ➖, 0↑ 3↓)
datafusion / vortex-compact (1.015x ➖, 0↑ 0↓)
datafusion / parquet (0.955x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.023x ➖, 1↑ 1↓)
duckdb / vortex-compact (1.008x ➖, 0↑ 1↓)
duckdb / parquet (0.993x ➖, 1↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: FineWeb NVMeNo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.005x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.992x ➖, 0↑ 0↓)
datafusion / parquet (0.965x ➖, 4↑ 1↓)
datafusion / arrow (1.005x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (0.995x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.003x ➖, 0↑ 0↓)
duckdb / parquet (1.004x ➖, 0↑ 1↓)
duckdb / duckdb (0.998x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.896x ✅, 49↑ 0↓)
datafusion / vortex-compact (0.917x ➖, 31↑ 0↓)
datafusion / parquet (0.912x ➖, 33↑ 1↓)
duckdb / vortex-file-compressed (0.900x ✅, 46↑ 0↓)
duckdb / vortex-compact (0.928x ➖, 24↑ 1↓)
duckdb / parquet (0.947x ➖, 9↑ 2↓)
duckdb / duckdb (0.913x ➖, 29↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-DS SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.064x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.925x ➖, 1↑ 0↓)
datafusion / parquet (1.084x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.061x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.009x ➖, 0↑ 0↓)
duckdb / parquet (1.056x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (1.013x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.002x ➖, 0↑ 0↓)
duckdb / parquet (1.019x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: Statistical and Population GeneticsNo file size changes detected. |
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/bump-toolchain
branch
from
4f48946 to
2a811b7
Compare
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.126x ❌, 0↑ 18↓)
datafusion / vortex-compact (1.009x ➖, 7↑ 5↓)
datafusion / parquet (1.098x ➖, 0↑ 12↓)
datafusion / arrow (1.084x ➖, 0↑ 11↓)
duckdb / vortex-file-compressed (1.127x ❌, 0↑ 17↓)
duckdb / vortex-compact (1.114x ❌, 0↑ 15↓)
duckdb / parquet (1.059x ➖, 0↑ 2↓)
duckdb / duckdb (1.065x ➖, 0↑ 3↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=10 on NVMENo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.070x ➖, 0↑ 1↓)
datafusion / vortex-compact (0.938x ➖, 4↑ 0↓)
datafusion / parquet (1.042x ➖, 2↑ 3↓)
duckdb / vortex-file-compressed (1.017x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.995x ➖, 0↑ 0↓)
duckdb / parquet (0.997x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.022x ➖, 0↑ 1↓)
datafusion / parquet (1.021x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.016x ➖, 2↑ 4↓)
duckdb / parquet (1.003x ➖, 1↑ 0↓)
duckdb / duckdb (0.989x ➖, 4↑ 1↓)
Full attributed analysis
|
Contributor
File Sizes: Clickbench on NVMEFile Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
Benchmarks: CompressionVortex (geomean): 0.988x ➖ unknown / unknown (0.966x ➖, 13↑ 2↓)
|
Contributor
Benchmarks: Random AccessVortex (geomean): 1.050x ➖ unknown / unknown (1.105x ❌, 1↑ 10↓)
|
AdamGS
changed the title
Contributor
Author
|
@robert3005 given that 1.95 was released last week, should we bump to 1.92 while we're doing this? |
Contributor
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.018x ➖, 0↑ 2↓)
datafusion / vortex-compact (1.006x ➖, 2↑ 2↓)
datafusion / parquet (0.952x ➖, 2↑ 2↓)
duckdb / vortex-file-compressed (0.959x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.980x ➖, 0↑ 0↓)
duckdb / parquet (0.968x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
|
While we can bump to 1.92 I wouldn't bump beyond what we have a need for |
Contributor
|
I think we've roughly been following DF to date and trying to keep a window of stable versions, but you're right we haven't bumped it in awhile. This is 4 releases behind latest stable so seems safe to me EDIT: I see rob's comment to the same effect now buried in the middle of a bunch of benchmark result comments |
Contributor
Author
|
So lets keep it at this? @a10y @robert3005 |
robert3005
reviewed
Apr 22, 2026
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
robert3005
approved these changes
Apr 22, 2026
a10y
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're two major version back on our lance comparison (which is about 2 months of changes), but it also seems like more and more dependencies break because we're on 1.90.
libs.rs says 68% of crates.io requests ask for this stable version or newer, not sure what was our bar in the past but I figured its worth at least checking it out.
I've reviewed the changes and none of them seem substantial, they are all tests and some lints that were improved and don't warn anymore.