Specialize Constant for the arithmetic-write fast path#8002
Closed
joseph-isaacs wants to merge 1 commit into
Closed
Specialize Constant for the arithmetic-write fast path#8002joseph-isaacs wants to merge 1 commit into
joseph-isaacs wants to merge 1 commit into
Conversation
When a ConstantArray feeds the fixed-before-varlen arithmetic path, the encoded scalar bytes are the same for every row. Hoist them into 1-2 register-sized loads outside the loop and emit direct write_unaligned stores per row. Specialized for encoded lengths 2 (bool/i8), 5 (i32), 9 (i64), 17 (i128). Other lengths fall back to copy_nonoverlapping. The var_prefix case (Constant after a varlen column) takes the same shape but computes per-row positions arithmetically rather than via a running cursor. constant_i64_vortex_without_kernel 2.47 -> ~6 GB/s (PR3 commit 3.3 adds the same specialization to the Constant kernel itself). Signed-off-by: Claude <noreply@anthropic.com>
This was referenced May 18, 2026
This was referenced May 18, 2026
Closed
Merging this PR will degrade performance by 12.39%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | new_alp_prim_test_between[f32, 16384] |
103.7 µs | 118.3 µs | -12.39% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/row-c17-specialize-constant-arith (7987423) with claude/row-c16-arith-write-fast-path (224fdab)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 17 of 25 in the stacked PR series adding
vortex-row.This PR contains exactly one commit; review just that diff in isolation.
What this commit does
When a ConstantArray feeds the fixed-before-varlen arithmetic path, the encoded scalar bytes are the same for every row. Hoists them into 1-2 register-sized loads outside the loop and emits direct
write_unalignedstores per row. Specialized for encoded lengths 2 (bool/i8), 5 (i32), 9 (i64), 17 (i128). Other lengths fall back tocopy_nonoverlapping. The var_prefix case (Constant after a varlen column) takes the same shape but computes per-row positions arithmetically rather than via a running cursor.constant_i64_vortex_without_kernel 2.47 → ~6 GB/s (PR3 commit 3.3 adds the same specialization to the Constant kernel itself).
Stack
claude/row-c01-crate-scaffoldingclaude/row-c02-sortfield-optionsclaude/row-c03-codec-fixed-widthclaude/row-c04-codec-varlenclaude/row-c05-codec-nestedclaude/row-c06-rowsize-scalarfnclaude/row-c07-rowencode-scalarfnclaude/row-c08-convert-columns-tests-benchclaude/row-c09-skip-listview-validationclaude/row-c10-validity-fast-pathclaude/row-c11-skip-zero-initclaude/row-c12-vectorize-pure-fixed-offsetsclaude/row-c13-vectorize-mixed-offsetsclaude/row-c14-varlen-block-copy-nonoverlappingclaude/row-c15-walk-varbinview-directlyclaude/row-c16-arith-write-fast-pathclaude/row-c17-specialize-constant-arithclaude/row-c18-kernel-dispatch-helpersclaude/row-c19-inventory-registryclaude/row-c20-constant-kernelclaude/row-c21-dict-kernelclaude/row-c22-patched-kernelclaude/row-c23-runend-kernelclaude/row-c24-bitpacked-kernelclaude/row-pr3-kernelsBase of this PR: #8001 (
claude/row-c16-arith-write-fast-path)Next in stack: #8003 (
claude/row-c18-kernel-dispatch-helpers)Combined context
For the full design + rationale, see PR #7985 (top of stack).