Skip to content

RowSizeKernel and RowEncodeKernel dispatch helpers#8003

Closed
joseph-isaacs wants to merge 1 commit into
claude/row-c17-specialize-constant-arithfrom
claude/row-c18-kernel-dispatch-helpers
Closed

RowSizeKernel and RowEncodeKernel dispatch helpers#8003
joseph-isaacs wants to merge 1 commit into
claude/row-c17-specialize-constant-arithfrom
claude/row-c18-kernel-dispatch-helpers

Conversation

@joseph-isaacs
Copy link
Copy Markdown
Contributor

@joseph-isaacs joseph-isaacs commented May 18, 2026

Part 18 of 25 in the stacked PR series adding vortex-row.

This PR contains exactly one commit; review just that diff in isolation.

What this commit does

Wires per-encoding fast-path traits into dispatch_size and dispatch_encode. Both helpers now try the in-crate downcast arms (Constant, Dict, Patched) before falling back to canonicalization.

This commit adds stub impls returning Ok(None) so the existing behavior is preserved bit-for-bit; subsequent commits replace each stub with its real impl. Keeping the wiring change separate from the algorithm work makes the kernel impl commits trivially reviewable in isolation (they only touch one file each).

The kernel module is mod kernels (crate-private) so the impls satisfy the orphan rule (trait defined in vortex-row, types from vortex-array) without leaking the impls into the crate's public surface.

Stack

# PR Title Branch
1 #7986 vortex-row: crate scaffolding claude/row-c01-crate-scaffolding
2 #7987 vortex-row: add SortField and RowEncodeOptions claude/row-c02-sortfield-options
3 #7988 vortex-row: codec for fixed-width canonical types claude/row-c03-codec-fixed-width
4 #7989 vortex-row: codec for varlen canonical types claude/row-c04-codec-varlen
5 #7990 vortex-row: codec for nested canonical types claude/row-c05-codec-nested
6 #7991 vortex-row: compute_sizes helper and RowSize ScalarFn claude/row-c06-rowsize-scalarfn
7 #7992 vortex-row: RowEncode ScalarFn claude/row-c07-rowencode-scalarfn
8 #7993 vortex-row: convert_columns + tests + bench scaffolding claude/row-c08-convert-columns-tests-bench
9 #7994 Skip ListView validation in row encoder output claude/row-c09-skip-listview-validation
10 #7995 Add validity fast-path helper for the four pattern-matching encoders claude/row-c10-validity-fast-path
11 #7996 Skip zero-init of output buffer claude/row-c11-skip-zero-init
12 #7997 Auto-vectorize pure-fixed offsets construction claude/row-c12-vectorize-pure-fixed-offsets
13 #7998 Auto-vectorize mixed-path offsets construction claude/row-c13-vectorize-mixed-offsets
14 #7999 Rewrite varlen 32-byte block encoder with copy_nonoverlapping claude/row-c14-varlen-block-copy-nonoverlapping
15 #8000 Walk VarBinView rows directly in row encoder hot loop claude/row-c15-walk-varbinview-directly
16 #8001 Add arithmetic-write fast path for fixed-before-varlen columns claude/row-c16-arith-write-fast-path
17 #8002 Specialize Constant for the arithmetic-write fast path claude/row-c17-specialize-constant-arith
18 #8003 RowSizeKernel and RowEncodeKernel dispatch helpers claude/row-c18-kernel-dispatch-helpers
19 #8004 Inventory-based registry for downstream encoding kernels claude/row-c19-inventory-registry
20 #8005 Constant row-encode kernel claude/row-c20-constant-kernel
21 #8006 Dict row-encode kernel claude/row-c21-dict-kernel
22 #8007 Patched row-encode kernel claude/row-c22-patched-kernel
23 #8008 RunEnd row-encode kernel (vortex-runend) claude/row-c23-runend-kernel
24 #8009 BitPacked row-encode kernel (vortex-fastlanes) claude/row-c24-bitpacked-kernel
25 #7985 FoR and Delta row-encode kernels (vortex-fastlanes) claude/row-pr3-kernels

Base of this PR: #8002 (claude/row-c17-specialize-constant-arith)
Next in stack: #8004 (claude/row-c19-inventory-registry)

Combined context

For the full design + rationale, see PR #7985 (top of stack).

Wire per-encoding fast-path traits into `dispatch_size` and
`dispatch_encode`. Both helpers now try the in-crate downcast arms
(Constant, Dict, Patched) before falling back to canonicalization.

This commit adds stub impls returning `Ok(None)` so the existing
behavior is preserved bit-for-bit; subsequent commits replace each
stub with its real impl. Keeping the wiring change separate from the
algorithm work makes the kernel impl commits trivially reviewable in
isolation (they only touch one file each).

The kernel module is `mod kernels` (crate-private) so the impls
satisfy the orphan rule (trait defined in `vortex-row`, types from
`vortex-array`) without leaking the impls into the crate's public
surface.

Signed-off-by: Claude <noreply@anthropic.com>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 18, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 1218 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 224.8 µs 187.6 µs +19.81%
Simulation chunked_varbinview_canonical_into[(100, 100)] 273.3 µs 307.8 µs -11.21%
Simulation iter_arrow_buffer[128] 919.4 ns 831.9 ns +10.52%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing claude/row-c18-kernel-dispatch-helpers (f3c7593) with develop (faf7e42)1

Open in CodSpeed

Footnotes

  1. No successful run was found on claude/row-c17-specialize-constant-arith (7987423) during the generation of this report, so develop (faf7e42) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants