Skip to content

wipe duckdb source in build.rs if not fully extracted before#8106

Merged
onursatici merged 1 commit into
developfrom
os/duckdb-src
May 26, 2026
Merged

wipe duckdb source in build.rs if not fully extracted before#8106
onursatici merged 1 commit into
developfrom
os/duckdb-src

Conversation

@onursatici
Copy link
Copy Markdown
Contributor

Summary

Fix Result::unwrap() on an Err value: InvalidArchive("Symlink is not inherently safe")` when building vortex-duckdb and if a partially extracted archive exists on target

Signed-off-by: Onur Satici <onur@spiraldb.com>
@onursatici onursatici requested review from 0ax1 and myrrc May 26, 2026 14:50
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🥳

@onursatici onursatici added the changelog/fix A bug fix label May 26, 2026
@onursatici onursatici enabled auto-merge (squash) May 26, 2026 14:51
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 26, 2026

Merging this PR will degrade performance by 15.3%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 3 regressed benchmarks
✅ 1248 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 0.1)] 456.5 µs 517.1 µs -11.72%
Simulation take_map[(0.1, 0.5)] 993.8 µs 1,134.5 µs -12.4%
Simulation take_map[(0.1, 1.0)] 1.7 ms 2.2 ms -21.43%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing os/duckdb-src (c4175e3) with develop (4823563)

Open in CodSpeed

@onursatici onursatici merged commit f900433 into develop May 26, 2026
70 of 72 checks passed
@onursatici onursatici deleted the os/duckdb-src branch May 26, 2026 14:58
@0ax1
Copy link
Copy Markdown
Contributor

0ax1 commented May 26, 2026

Do we prefer this over atomic swap-in of extracted dirs from tmp?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants