Skip to content

wipe duckdb source in build.rs if not fully extracted before #8106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onursatici merged 1 commit into from
May 26, 2026
Merged

wipe duckdb source in build.rs if not fully extracted before #8106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions vortex-duckdb/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

use std::env;
use std::fs;
use std::io;
use std::os::unix::fs::symlink;
use std::path::Path;
use std::path::PathBuf;
Expand Down Expand Up @@ -278,7 +279,7 @@ fn try_build_duckdb(

let library_dir_str = library_dir.display();
if let Err(err) = fs::remove_dir_all(library_dir)
&& err.kind() != std::io::ErrorKind::NotFound
&& err.kind() != io::ErrorKind::NotFound
{
println!("cargo:error=Failed to remove {library_dir_str}: {err}");
exit(1);
Expand Down Expand Up @@ -440,13 +441,24 @@ fn main() {
DuckDBVersion::Commit(c) => format!("{DUCKDB_SOURCE_COMMIT_URL}/{c}.zip"),
};

fs::create_dir_all(&source_dir).unwrap();
let source_archive_path = source_dir.with_extension("zip");
download_url(&source_archive_url, &source_archive_path);

let inner_dir = source_dir.join(version.archive_inner_dir_name());
if !inner_dir.join("CMakeLists.txt").exists() {
let extract_marker = source_dir.join(".vx-extract-complete");
if !extract_marker.exists() {
if let Err(err) = fs::remove_dir_all(&source_dir)
&& err.kind() != io::ErrorKind::NotFound
{
println!(
"cargo:error=Failed to clear {}: {err}",
source_dir.display()
);
exit(1);
}
fs::create_dir_all(&source_dir).unwrap();
extract(&source_archive_path, &source_dir);
fs::write(&extract_marker, version.to_string()).unwrap();
}

drop(fs::remove_file(&duckdb_dir));
Expand Down
Loading