Fix native library publish for non amd64 platforms#8108
Merged
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
AdamGS
reviewed
May 27, 2026
| runner: macos-latest | ||
| fallback_runner: macos-latest | ||
| archive: tgz | ||
| - target: x86_64-apple-darwin |
Contributor
There was a problem hiding this comment.
maybe we should take the opportunity and just remove it?
Contributor
There was a problem hiding this comment.
also - can't we cross-compile to mac from linux?
Contributor
Author
There was a problem hiding this comment.
I haven't looked into it. For removal we can wait until macos 27 is out imho and see what people do then
AdamGS
reviewed
May 27, 2026
Comment on lines
+44
to
+45
| with: | ||
| sccache: s3 |
Contributor
There was a problem hiding this comment.
I think in general we try not to use caches for binary releases to make sure they are not poisoned? I might be wrong here.
AdamGS
reviewed
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When publishing native packages make sure different architectures don't override
each other