-
Notifications
You must be signed in to change notification settings - Fork 160
Fix native library publish for non amd64 platforms #8108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+63
−17
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,25 +10,40 @@ permissions: | |
| jobs: | ||
| build: | ||
| name: Build ${{ matrix.target }} | ||
| runs-on: ${{ matrix.runs-on }} | ||
| runs-on: >- | ||
| ${{ github.repository == 'vortex-data/vortex' | ||
| && matrix.runner | ||
| || matrix.fallback_runner }} | ||
| timeout-minutes: 120 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - target: aarch64-apple-darwin | ||
| runs-on: macos-latest | ||
| runner: macos-latest | ||
| fallback_runner: macos-latest | ||
| archive: tgz | ||
| - target: x86_64-apple-darwin | ||
| runs-on: macos-15-intel | ||
| runner: macos-15-intel | ||
| fallback_runner: macos-15-intel | ||
| archive: tgz | ||
| # Linux targets cross-compile from an amd64 runs-on runner via | ||
| # cargo-zigbuild with glibc 2.31 pinning, matching the Python wheel | ||
| # and JNI builds. | ||
| - target: aarch64-unknown-linux-gnu | ||
| runs-on: ubuntu-24.04-arm | ||
| runner: runs-on=${{ github.run_id }}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/tag=release-vx-aarch64-linux | ||
| fallback_runner: ubuntu-24.04 | ||
| archive: tgz | ||
| - target: x86_64-unknown-linux-gnu | ||
| runs-on: ubuntu-24.04 | ||
| runner: runs-on=${{ github.run_id }}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/tag=release-vx-amd64-linux | ||
| fallback_runner: ubuntu-24.04 | ||
| archive: tgz | ||
| steps: | ||
| - uses: runs-on/action@v2 | ||
| if: github.repository == 'vortex-data/vortex' && contains(matrix.target, 'linux') | ||
| with: | ||
| sccache: s3 | ||
|
Comment on lines
+44
to
+45
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think in general we try not to use caches for binary releases to make sure they are not poisoned? I might be wrong here. |
||
|
|
||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
@@ -37,9 +52,24 @@ jobs: | |
| with: | ||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
| targets: ${{ matrix.target }} | ||
| enable-sccache: "false" | ||
| enable-sccache: ${{ contains(matrix.target, 'linux') && 'true' || 'false' }} | ||
|
|
||
| - name: Setup Zig | ||
| if: contains(matrix.target, 'linux') | ||
| uses: mlugg/setup-zig@d1434d08867e3ee9daa34448df10607b98908d29 # v2.2.1 | ||
|
|
||
| - name: Install cargo-zigbuild | ||
| if: contains(matrix.target, 'linux') | ||
| uses: taiki-e/cache-cargo-install-action@66c9585ef5ca780ee69399975a5e911f47905995 | ||
| with: | ||
| tool: cargo-zigbuild | ||
|
|
||
| - name: Build release binary (Linux, zigbuild) | ||
| if: contains(matrix.target, 'linux') | ||
| run: cargo zigbuild --release --package vortex-tui --bin vx --target ${{ matrix.target }}.2.31 | ||
|
|
||
| - name: Build release binary | ||
| - name: Build release binary (macOS) | ||
| if: contains(matrix.target, 'apple-darwin') | ||
| run: cargo build --release --package vortex-tui --bin vx --target ${{ matrix.target }} | ||
|
|
||
| - name: Create archive (tgz) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should take the opportunity and just remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also - can't we cross-compile to mac from linux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked into it. For removal we can wait until macos 27 is out imho and see what people do then