sccache cleanup#8669
Conversation
|
Why should this not be turned on by default? |
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
795751d to
78b2758
Compare
|
curious about a 2nd opinion here. @robert3005 |
Merging this PR will improve performance by 11.98%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
244.4 ns | 215.3 ns | +13.55% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
306.9 µs | 272.1 µs | +12.81% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(100, 100)] |
340.6 µs | 305.4 µs | +11.53% |
| ⚡ | Simulation | rebuild_naive |
101.9 µs | 91.4 µs | +11.47% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
304.7 ns | 275.6 ns | +10.58% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing adamg/sccache-pass (33d6b69) with develop (e6c312a)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
0ax1
left a comment
There was a problem hiding this comment.
in the name of consistency.
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
|
c/cpp runs into some issues with our cmakelists, will fix in a followup. |
Rationale for this change
Make better use of sccache across our GH actions workflows.
What changes are included in this PR?
What APIs are changed? Are there any user-facing changes?
None