Skip to content

sccache cleanup#8669

Merged
AdamGS merged 2 commits into
developfrom
adamg/sccache-pass
Jul 7, 2026
Merged

sccache cleanup#8669
AdamGS merged 2 commits into
developfrom
adamg/sccache-pass

Conversation

@AdamGS

@AdamGS AdamGS commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

Make better use of sccache across our GH actions workflows.

What changes are included in this PR?

  1. Makes sccache opt in
  2. When sccache is used, make sure its properly configured with runs-on.

What APIs are changed? Are there any user-facing changes?

None

@0ax1

0ax1 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Why should this not be turned on by default?

@vortex-data vortex-data deleted a comment from github-actions Bot Jul 7, 2026
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS
AdamGS force-pushed the adamg/sccache-pass branch from 795751d to 78b2758 Compare July 7, 2026 12:40
@0ax1

0ax1 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

curious about a 2nd opinion here. @robert3005

@codspeed-hq

codspeed-hq Bot commented Jul 7, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 11.98%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 5 improved benchmarks
✅ 1640 untouched benchmarks
⏩ 4 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 215.3 ns +13.55%
Simulation chunked_varbinview_into_canonical[(100, 100)] 306.9 µs 272.1 µs +12.81%
Simulation chunked_varbinview_opt_canonical_into[(100, 100)] 340.6 µs 305.4 µs +11.53%
Simulation rebuild_naive 101.9 µs 91.4 µs +11.47%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 275.6 ns +10.58%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/sccache-pass (33d6b69) with develop (e6c312a)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@0ax1 0ax1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the name of consistency.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS

AdamGS commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

c/cpp runs into some issues with our cmakelists, will fix in a followup.

@AdamGS
AdamGS enabled auto-merge (squash) July 7, 2026 12:52
@AdamGS
AdamGS merged commit a4a11a5 into develop Jul 7, 2026
69 of 70 checks passed
@AdamGS
AdamGS deleted the adamg/sccache-pass branch July 7, 2026 12:58
@AdamGS
AdamGS temporarily deployed to github-pages July 7, 2026 13:03 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants