fix: TableStrategy currently hides panic in spawned column writer tasks.#8672
Merged
Merged
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
4c33887 to
9824901
Compare
Merging this PR will not alter performance
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
robert3005
approved these changes
Jul 7, 2026
robert3005
pushed a commit
that referenced
this pull request
Jul 8, 2026
## Rationale for this change Following #8672, I've audited a few other suspicous code paths that had similar shape, mostly on the read side. ## What changes are included in this PR? 1. Propagate panics and shutdown correctly for `FileSegmentSource`. 2. Handle panics correctly in the shared iterator used by DuckDB 3. Misc panic handling around our runtime abstraction. ## What APIs are changed? Are there any user-facing changes? None --------- Signed-off-by: Adam Gutglick <adam@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
TableStrategycurrently hides panics that happen in the individual column streams.What changes are included in this PR?
Instead of detaching the fanout work, we await it and make sure everything finishes successfully.
What APIs are changed? Are there any user-facing changes?
No API change, added test to verify panic propagation.