Skip to content

remove old c++ api#8736

Merged
myrrc merged 1 commit into
developfrom
myrrc/rm-cxx
Jul 13, 2026
Merged

remove old c++ api#8736
myrrc merged 1 commit into
developfrom
myrrc/rm-cxx

Conversation

@myrrc

@myrrc myrrc commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This is first pr in a stack for migrating to new c++ api.

@myrrc myrrc requested a review from 0ax1 July 13, 2026 12:57
@myrrc myrrc added the changelog/break A breaking API change label Jul 13, 2026
@myrrc myrrc enabled auto-merge (squash) July 13, 2026 12:57
@codspeed-hq

codspeed-hq Bot commented Jul 13, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 8 improved benchmarks
❌ 5 regressed benchmarks
✅ 1693 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_canonical_into[(1000, 10)] 154 µs 191.2 µs -19.44%
Simulation encode_varbin[(1000, 4)] 139 µs 157.7 µs -11.81%
Simulation chunked_varbinview_into_canonical[(100, 100)] 271.6 µs 306.7 µs -11.46%
Simulation encode_varbin[(1000, 8)] 139.9 µs 157.6 µs -11.27%
Simulation encode_varbin[(1000, 2)] 138.5 µs 154.7 µs -10.46%
Simulation chunked_bool_canonical_into[(1000, 10)] 26.5 µs 16.2 µs +63.99%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 205.7 µs 169.5 µs +21.36%
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 205.8 µs 169.8 µs +21.2%
Simulation chunked_varbinview_opt_into_canonical[(1000, 10)] 219.5 µs 183.3 µs +19.76%
Simulation chunked_varbinview_canonical_into[(100, 100)] 258.5 µs 223.6 µs +15.61%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 215.3 ns +13.55%
Simulation compare_int_constant 298.7 µs 268.8 µs +11.14%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 275.6 ns +10.58%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/rm-cxx (9670382) with develop (a6513a0)

Open in CodSpeed

@myrrc myrrc force-pushed the myrrc/rm-cxx branch 4 times, most recently from c2b7173 to de6dc7d Compare July 13, 2026 13:13
@myrrc myrrc added the lang/cpp Relates to the Vortex C++ API label Jul 13, 2026
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc merged commit c27a612 into develop Jul 13, 2026
74 of 75 checks passed
@myrrc myrrc deleted the myrrc/rm-cxx branch July 13, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change lang/cpp Relates to the Vortex C++ API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants