Remove Arrow macro benchmarks#8816
Open
AdamGS wants to merge 3 commits into
Open
Conversation
AdamGS
added
changelog/ci
action/benchmark
github-actions
Bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (3)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: Vortex queriesVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.031x ➖, 0↑ 0↓)
datafusion / parquet (0.958x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.000x ➖, 0↑ 0↓)
duckdb / parquet (1.011x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 0.978x ➖ How to read Verdict and Engines
datafusion / vortex-file-compressed (0.978x ➖, 1↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.060x ➖, 0↑ 1↓)
datafusion / vortex-compact (1.026x ➖, 0↑ 1↓)
datafusion / parquet (1.043x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.064x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.047x ➖, 0↑ 1↓)
duckdb / parquet (1.040x ➖, 0↑ 1↓)
No file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.040x ➖, 0↑ 0↓)
datafusion / vortex-compact (1.041x ➖, 0↑ 0↓)
datafusion / parquet (1.031x ➖, 0↑ 2↓)
duckdb / vortex-file-compressed (1.043x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.048x ➖, 0↑ 0↓)
duckdb / parquet (1.031x ➖, 0↑ 2↓)
duckdb / duckdb (1.043x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.074x ➖, 0↑ 18↓)
datafusion / vortex-compact (1.063x ➖, 0↑ 12↓)
datafusion / parquet (1.080x ➖, 0↑ 27↓)
duckdb / vortex-file-compressed (1.049x ➖, 0↑ 17↓)
duckdb / vortex-compact (1.044x ➖, 0↑ 6↓)
duckdb / parquet (1.029x ➖, 0↑ 3↓)
duckdb / duckdb (1.054x ➖, 0↑ 6↓)
No file size changes detected. |
Merging this PR will not alter performance
|
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.908x ➖, 1↑ 0↓)
datafusion / vortex-compact (0.953x ➖, 0↑ 0↓)
datafusion / parquet (1.024x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.007x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.016x ➖, 0↑ 0↓)
duckdb / parquet (0.999x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.935x ➖, 2↑ 0↓)
datafusion / vortex-compact (0.937x ➖, 1↑ 0↓)
datafusion / parquet (0.924x ➖, 3↑ 0↓)
duckdb / vortex-file-compressed (0.961x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.962x ➖, 0↑ 0↓)
duckdb / parquet (0.975x ➖, 0↑ 0↓)
duckdb / duckdb (0.973x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) How to read Verdict and Engines
duckdb / vortex-file-compressed (0.986x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.996x ➖, 0↑ 0↓)
duckdb / parquet (0.988x ➖, 0↑ 0↓)
No file size changes detected. |
Member
|
Hmmm I do feel like it was nice to see this in the benchmarks website to see how we perform against in-memory stuff. Maybe we can do this on commit / develop and nightly only and remove from pr benches? |
Contributor
Benchmarks: Clickbench Sorted on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.082x ➖, 0↑ 4↓)
datafusion / parquet (1.060x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.139x ❌, 0↑ 4↓)
duckdb / parquet (1.006x ➖, 0↑ 0↓)
duckdb / duckdb (1.034x ➖, 0↑ 0↓)
File Size Changes (201 files changed, -0.0% overall, 95↑ 106↓)
Totals:
|
Contributor
Benchmarks: Random AccessVortex (geomean): 1.001x ➖ How to read Verdict and Engines
unknown / unknown (0.995x ➖, 1↑ 0↓)
|
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.948x ➖, 11↑ 0↓)
datafusion / parquet (0.951x ➖, 10↑ 0↓)
duckdb / vortex-file-compressed (0.971x ➖, 9↑ 0↓)
duckdb / parquet (0.975x ➖, 6↑ 0↓)
duckdb / duckdb (0.971x ➖, 2↑ 0↓)
File Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.064x ➖, 0↑ 4↓)
datafusion / vortex-compact (1.017x ➖, 1↑ 0↓)
datafusion / parquet (1.148x ➖, 0↑ 4↓)
duckdb / vortex-file-compressed (1.029x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.026x ➖, 0↑ 0↓)
duckdb / parquet (1.027x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Appian on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.030x ➖, 0↑ 0↓)
datafusion / parquet (1.017x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.009x ➖, 0↑ 0↓)
duckdb / parquet (1.018x ➖, 0↑ 0↓)
duckdb / duckdb (1.012x ➖, 0↑ 0↓)
File Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.000x ➖, 0↑ 0↓)
datafusion / vortex-compact (1.027x ➖, 1↑ 0↓)
datafusion / parquet (1.036x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.015x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.988x ➖, 0↑ 0↓)
duckdb / parquet (1.016x ➖, 0↑ 0↓)
|
robert3005
reviewed
Jul 17, 2026
connortsui20
requested changes
Jul 17, 2026
connortsui20
left a comment
connortsui20
left a comment
Member
There was a problem hiding this comment.
Oh and also if we're taking arrow out as an engine we need to update the benchmarks website. I think I would still like to measure this on nightly and maybe even ever commit (but we can get rid of them on PR benches)
Contributor
Author
Why? |
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/remove-df-arrow
branch
from
July 17, 2026 13:14
bc82ad9 to
c17ff9e
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/remove-df-arrow
branch
from
July 17, 2026 13:16
c17ff9e to
39d3ca5
Compare
Contributor
Benchmarks: CompressionVortex (geomean): 0.998x ➖ How to read Verdict and Engines
unknown / unknown (0.991x ➖, 2↑ 0↓)
|
Member
|
To elaborate, it's nice to see a comparison where we can say "oh it's not too far off from in-memory perf", or in some cases "it's better than uncompressed arrow perf" |
Contributor
Author
|
Its a very bad comparison, the DataFusion's in-memory source has the following problems:
|
Member
|
thats fair, but to me this is an implementation detail vs a reason to remove it? The reason I suggested it on develop and nightly only was that we might as well measure it so we can put it on the website, unless you think that it shouldn't be there at all? |
connortsui20
self-requested a review
July 17, 2026 14:44
connortsui20
approved these changes
Jul 17, 2026
connortsui20
left a comment
connortsui20
left a comment
Member
There was a problem hiding this comment.
It seems like the main reason we are deleting this is for maintainability. I think it is debatable that this is a "useless" benchmark, but if it makes everything else easier then it should be fine to remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Arrow macro benchmarks are very noisy and have many dependencies on minor details of their implementations. They are not a real target either.
What changes are included in this PR?
Removes any mention of arrow from the macro benchmarks (both sql and compression/random access)
What APIs are changed? Are there any user-facing changes?
N/A