Prevent non empty unions and clarify null docs#8882
Merged
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
robert3005
approved these changes
Jul 21, 2026
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: Vortex queries 📖Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.045x ➖, 0↑ 0↓)
datafusion / parquet (0.971x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.019x ➖, 0↑ 0↓)
duckdb / parquet (1.001x ➖, 0↑ 0↓)
No file size changes detected. |
connortsui20
enabled auto-merge (squash)
July 21, 2026 16:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Tracking issue: #8769
What changes are included in this PR?
As discussed offline, we have decided to disallow empty unions because we do not think there is a good usecase for it. And as you can see in the diffs here, that meant we could not choose a good default for the "zero value" of scalars.
This PR prevents empty unions, as well as clarifies some of the null docs around the union scalar accessors.
What APIs are changed? Are there any user-facing changes?
Some name changes to make things more obvious