Skip to content

refactor[array]: serialization context filter by ids (not whole registry)#8897

Merged
joseph-isaacs merged 2 commits into
developfrom
agent/context-valid-ids
Jul 22, 2026
Merged

refactor[array]: serialization context filter by ids (not whole registry)#8897
joseph-isaacs merged 2 commits into
developfrom
agent/context-valid-ids

Conversation

@joseph-isaacs

Copy link
Copy Markdown
Contributor

The serialization context only needs registry IDs for filtering, so it now snapshots those IDs instead of retaining the entire registry.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codspeed-hq

codspeed-hq Bot commented Jul 22, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 1847 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing agent/context-valid-ids (fdc2ca3) with develop (037b1a8)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Polar Signals Profiling Results

Latest Run

Status Commit Job Attempt Link
🟢 Done fdc2ca3 1 Explore Profiling Data
Previous Runs (1)
Status Commit Job Attempt Link
🟢 Done 3138b60 1 Explore Profiling Data

Powered by Polar Signals Cloud

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Benchmarks: Vortex queries 📖

Verdict: No clear signal (low confidence)
Attributed Vortex impact: +0.8%
Engines: DataFusion No clear signal (+7.0%, low confidence) · DuckDB No clear signal (-5.0%, low confidence)
Vortex (geomean): 0.962x ➖
Parquet (geomean): 0.958x ➖
Shifts: Parquet (control) -4.2% · Median polish -3.6%

How to read Verdict and Engines
  • Verdict: Overall PR-level signal after subtracting baseline drift estimated from Parquet control rows. It can be Likely improvement, Likely regression, or No clear signal.
  • Engines: Per-engine attribution. DataFusion is compared against DataFusion/Parquet controls; DuckDB is compared against DuckDB/Parquet controls. This answers whether each engine improved or regressed independently.
  • Confidence: Based on directional consistency, share of rows above the noise floor, and control-run noise.

datafusion / vortex-file-compressed (0.993x ➖, 0↑ 0↓)
name PR fdc2ca3 (ns) base c0d1a4e (ns) ratio (PR/base)
vortex_q00/datafusion:vortex-file-compressed 9849458 9821687 1.00
vortex_q01/datafusion:vortex-file-compressed 6129375 6238822 0.98
datafusion / parquet (0.927x ➖, 0↑ 0↓)
name PR fdc2ca3 (ns) base c0d1a4e (ns) ratio (PR/base)
vortex_q00/datafusion:parquet 20225869 21655580 0.93
vortex_q01/datafusion:parquet 4485219 4870956 0.92
duckdb / vortex-file-compressed (0.940x ➖, 0↑ 0↓)
name PR fdc2ca3 (ns) base c0d1a4e (ns) ratio (PR/base)
vortex_q00/duckdb:vortex-file-compressed 9869567 10494664 0.94
vortex_q01/duckdb:vortex-file-compressed 5964474 6351326 0.94
duckdb / parquet (0.989x ➖, 0↑ 0↓)
name PR fdc2ca3 (ns) base c0d1a4e (ns) ratio (PR/base)
vortex_q00/duckdb:parquet 23322040 23499817 0.99
vortex_q01/duckdb:parquet 9426531 9559125 0.99

No file size changes detected.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs
joseph-isaacs requested a review from robert3005 July 22, 2026 15:11
@joseph-isaacs
joseph-isaacs marked this pull request as ready for review July 22, 2026 15:11
@joseph-isaacs joseph-isaacs added the changelog/chore A trivial change label Jul 22, 2026
@joseph-isaacs
joseph-isaacs enabled auto-merge (squash) July 22, 2026 16:16
@joseph-isaacs joseph-isaacs changed the title refactor: store valid IDs in serialization context refactor[array]: serialization context filter by ids (not whole registry) Jul 22, 2026
@joseph-isaacs
joseph-isaacs merged commit 759562a into develop Jul 22, 2026
73 checks passed
@joseph-isaacs
joseph-isaacs deleted the agent/context-valid-ids branch July 22, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants