Skip to content

Don't emit STB_UNIQUE symbols in GCC for vortex-duckdb#8913

Merged
myrrc merged 1 commit into
developfrom
myrrc/duckdb-constexpr-inline-odr-violation
Jul 23, 2026
Merged

Don't emit STB_UNIQUE symbols in GCC for vortex-duckdb#8913
myrrc merged 1 commit into
developfrom
myrrc/duckdb-constexpr-inline-odr-violation

Conversation

@myrrc

@myrrc myrrc commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
myrrc requested a review from 0ax1 July 23, 2026 10:34
@myrrc myrrc added changelog/fix A bug fix changelog/skip Do not list PR in the changelog and removed changelog/skip Do not list PR in the changelog labels Jul 23, 2026
@myrrc
myrrc enabled auto-merge (squash) July 23, 2026 10:35
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Polar Signals Profiling Results

Latest Run

Status Commit Job Attempt Link
🟢 Done 73d7de8 1 Explore Profiling Data

Powered by Polar Signals Cloud

@github-actions

Copy link
Copy Markdown
Contributor

Benchmarks: Vortex queries 📖

Verdict: No clear signal (low confidence)
Attributed Vortex impact: +3.9%
Engines: DataFusion No clear signal (+6.2%, medium confidence) · DuckDB No clear signal (+1.7%, low confidence)
Vortex (geomean): 0.962x ➖
Parquet (geomean): 0.944x ➖
Shifts: Parquet (control) -5.6% · Median polish -2.7%

How to read Verdict and Engines
  • Verdict: Overall PR-level signal after subtracting baseline drift estimated from Parquet control rows. It can be Likely improvement, Likely regression, or No clear signal.
  • Engines: Per-engine attribution. DataFusion is compared against DataFusion/Parquet controls; DuckDB is compared against DuckDB/Parquet controls. This answers whether each engine improved or regressed independently.
  • Confidence: Based on directional consistency, share of rows above the noise floor, and control-run noise.

datafusion / vortex-file-compressed (0.950x ➖, 0↑ 0↓)
name PR 73d7de8 (ns) base 30091f2 (ns) ratio (PR/base)
vortex_q00/datafusion:vortex-file-compressed 8205234 8782896 0.93
vortex_q01/datafusion:vortex-file-compressed 5232249 5418053 0.97
datafusion / parquet (0.895x ✅, 1↑ 0↓)
name PR 73d7de8 (ns) base 30091f2 (ns) ratio (PR/base)
vortex_q00/datafusion:parquet 19999499 21877618 0.91
vortex_q01/datafusion:parquet 🚀 4510366 5149794 0.88
duckdb / vortex-file-compressed (1.013x ➖, 0↑ 0↓)
name PR 73d7de8 (ns) base 30091f2 (ns) ratio (PR/base)
vortex_q00/duckdb:vortex-file-compressed 10018914 10052416 1.00
vortex_q01/duckdb:vortex-file-compressed 6104779 5929380 1.03
duckdb / parquet (0.996x ➖, 0↑ 0↓)
name PR 73d7de8 (ns) base 30091f2 (ns) ratio (PR/base)
vortex_q00/duckdb:parquet 23352260 23618785 0.99
vortex_q01/duckdb:parquet 9451894 9419889 1.00

No file size changes detected.

@myrrc
myrrc merged commit 7654891 into develop Jul 23, 2026
89 of 92 checks passed
@myrrc
myrrc deleted the myrrc/duckdb-constexpr-inline-odr-violation branch July 23, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants