vortex-jni includes vortex-geo, jni arrow import/export uses session methods#8914
Merged
Conversation
…methods Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
enabled auto-merge (squash)
July 23, 2026 12:08
a10y
approved these changes
Jul 23, 2026
| pub(crate) fn new_session() -> Box<VortexSession> { | ||
| let session = VortexSession::default().with_handle(RUNTIME.handle()); | ||
| vortex_parquet_variant::initialize(&session); | ||
| vortex_geo::initialize(&session); |
Contributor
|
This should be an actual assertion, not debug_assert. Nothing else checks this, and anyone can call the Native* methods e.g. via reflection. |
0ax1
removed their request for review
July 23, 2026 13:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For iceberg support we want to include geo types, we already have all the logic
in vortex-geo. Adding vortex-geo exposed a bug where we weren't correctly using
session to export dtypes. vortex-jni by default bundles vortex-geo