duckdb: forbid reading files with duplicate struct field names#8917
Merged
Conversation
myrrc
added
changelog/fix
myrrc
enabled auto-merge (squash)
July 23, 2026 14:11
myrrc
force-pushed
the
myrrc/duckdb-forbid-struct-duplicate-fields
branch
from
July 23, 2026 14:12
cde335c to
b853c3b
Compare
0ax1
reviewed
Jul 23, 2026
| .map(|field_dtype| LogicalType::try_from(&field_dtype)) | ||
| .collect::<Result<_, _>>()?; | ||
|
|
||
| let mut name_set = HashSet::new(); |
Contributor
There was a problem hiding this comment.
Why not do the rename thing like Parquet?
Contributor
Author
There was a problem hiding this comment.
Because it's easier and signals to user there's something wrong instead of silently returning first column results. I believe Parquet reader should reject these as well.
0ax1
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #8710