feat(fuzz): row-encoding fuzz target for vortex-row#8955
Merged
Conversation
Generates 1-3 same-length columns of arbitrary dtypes with per-column RowSortField configs and checks three properties: - computed row sizes match the encoded key lengths - byte comparison of whole-array keys equals a logical tuple comparison under an independent total-order oracle (IEEE-754 total order for floats, positional nulls, leaf-only descending inversion) - keys stay comparable across separately encoded chunks, including chunks recompressed by btrblocks to different physical layouts The cross-chunk property reproduces the decimal key-width bug fixed in #8937 within minutes when run against develop without that fix. Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
a10y
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8937, where @a10y suggested a fuzz target for vortex-row.
What it does
Adds a
row_encodefuzz target that generates 1–3 same-length columns of arbitrary dtypes (via the existingArbitraryArraymachinery) with independent per-columnRowSortFieldconfigs (descending × nulls-first), and checks three properties:compute_row_sizes' per-row{fixed, var}totals equal the encoded key lengths.RowKey(recursive over structs/FSLs) and compares with the byte format's exact semantics, nulls positioned bynulls_firstregardless of direction, anddescendinginverting leaf values only.Unsupported dtypes (List, Variant, Union, Extension, Decimal256) assert that the encoder rejects them. The target is wired into the scheduled fuzz workflow like the existing targets.