Skip to content

mean(all null) = NULL - #9079

Merged
myrrc merged 3 commits into
developfrom
myrrc/mean-all-null-returns-null
Jul 30, 2026
Merged

mean(all null) = NULL#9079
myrrc merged 3 commits into
developfrom
myrrc/mean-all-null-returns-null

Conversation

@myrrc

@myrrc myrrc commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

#8365 introduced a behavior which is different from ANSI SQL and how query engines implement mean(all null), and reverting in #8389 was closed.

Revert this change, and add SLT duckdb/datafusion tests for current behaviour.

Resolves: #9083

@myrrc
myrrc requested a review from robert3005 July 30, 2026 11:31
@myrrc myrrc added changelog/fix A bug fix ext/duckdb Relates to the DuckDB integration labels Jul 30, 2026
@myrrc
myrrc force-pushed the myrrc/mean-all-null-returns-null branch from df2dcd3 to 0284158 Compare July 30, 2026 11:32
@myrrc
myrrc enabled auto-merge (squash) July 30, 2026 11:33
@myrrc myrrc added the ext/datafusion Relates to the DataFusion integration label Jul 30, 2026
@myrrc
myrrc disabled auto-merge July 30, 2026 12:09
Comment thread vortex-array/src/aggregate_fn/fns/mean/mod.rs Outdated
myrrc added 3 commits July 30, 2026 15:29
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
myrrc force-pushed the myrrc/mean-all-null-returns-null branch from 282e0f8 to 1f560bf Compare July 30, 2026 14:29
@myrrc
myrrc requested a review from joseph-isaacs July 30, 2026 14:30
@codspeed-hq

codspeed-hq Bot commented Jul 30, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 10.31%

❌ 1 regressed benchmark
✅ 1840 untouched benchmarks
⏩ 55 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation fsl_large 88.6 µs 98.8 µs -10.31%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/mean-all-null-returns-null (1f560bf) with develop (ae00c3b)

Open in CodSpeed

Footnotes

  1. 55 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@myrrc
myrrc merged commit 81c36da into develop Jul 30, 2026
103 of 105 checks passed
@myrrc
myrrc deleted the myrrc/mean-all-null-returns-null branch July 30, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix ext/datafusion Relates to the DataFusion integration ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mean(all null) is NaN in vortex-duckdb

2 participants