Benchmark unsigned 64-bit multiplication - #9211
Merged
Merged
Conversation
`binary_ops` covers `Mul` at every signed width and at `u8`, `u16` and `u32`, but not at `u64`. That width takes a different overflow check from the narrower unsigned ones, which have a wider native type to widen into, so it needs its own baseline before either is changed. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
AdamGS
approved these changes
Aug 5, 2026
connortsui20
enabled auto-merge (squash)
August 5, 2026 18:36
Merging this PR will improve performance by 12.87%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
mul_u64_nonnullcase tobinary_ops. The suite coversMulat every signed width and atu8,u16andu32, but not atu64, which takes a different overflow check because it has no wider native type to widen into.This lands separately so that CodSpeed records a baseline on
developbefore #9210 changes that check. Measured on that PR, the width gains 1.8x, which no existing benchmark would have caught.