Skip to content

Build benchmarks with whole-program optimization #9259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
connortsui20 wants to merge 1 commit into from
+9 −2
Closed

Build benchmarks with whole-program optimization #9259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,9 +409,16 @@ debug = "full"
inherits = "release"

[profile.bench]
codegen-units = 16
# Benchmarks exist to attribute a change in measurement to a change in code, so they are built
# whole-program. With `codegen-units = 16` and no LTO, adding unrelated code to a crate reshuffles
# which functions share a codegen unit, which changes cross-unit inlining for functions whose
# source did not change. That reports as a regression in code the branch never touched.
#
# `profile.release` deliberately keeps LTO off, because Vortex's performance must not depend on a
# downstream crate enabling it. That argument is about shipped code and does not apply here.
codegen-units = 1
debug = "full"
lto = false
lto = true

[profile.samply]
inherits = "release"
Expand Down
Loading